feat: serializable journal for bundlestate #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @prestwich and the rest of your teammates on |
Evalir
approved these changes
Sep 18, 2024
src/journal/coder.rs
Outdated
| #[derive(thiserror::Error, Debug, Copy, Clone, PartialEq, Eq)] | ||
| pub enum JournalDecodeError { | ||
| /// The buffer does not contain enough data to decode the type. | ||
| #[error("Buffer overrun while decoding {ty_name}. Expected {expected} bytes, but only {remaining} bytes remain.")] |
There was a problem hiding this comment.
nit: we usually keep errors without leading uppercase and without period for the closing sentence
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @prestwich and the rest of your teammates on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a serializable journal for bundlestate
This adds the
BundleStateIndexwhich generates a sorted index over aBundleState. The index can be serialized to a sorted, canonical format. The format is playable forwards and backwards. I.e. it can be used to apply blocks, or to rollback the same block