Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove naive seen_txns cache #32

Merged
merged 1 commit into from
Dec 13, 2024
Merged

fix: remove naive seen_txns cache #32

merged 1 commit into from
Dec 13, 2024

Conversation

anna-carroll
Copy link
Contributor

Given #31 , it's now possible to remove the naive solution of the seen_txns cache, and only filter transactions by whether they've been included on the rollup or not.

@anna-carroll
Copy link
Contributor Author

As we can see, at this point the TxPoller struct is an extremely simple wrapper for one function that calls the tx cache endpoint. It might make sense to refactor this, to combine it with the BundlePoller struct into a single TransactionCache struct which has two methods: get_transactions and get_bundles

Base automatically changed from anna/filter-confirmed to main December 12, 2024 22:58
Copy link
Collaborator

@prestwich prestwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

straightforward

@anna-carroll anna-carroll merged commit 59ba745 into main Dec 13, 2024
4 checks passed
@anna-carroll anna-carroll deleted the anna/remove-seen branch December 13, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants