Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Libdeflate 1.19 #128

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Libdeflate 1.19 #128

merged 3 commits into from
Jan 10, 2025

Conversation

tansy
Copy link
Collaborator

@tansy tansy commented Oct 10, 2023

Add libdeflate-1.19.

@tansy
Copy link
Collaborator Author

tansy commented Oct 10, 2023 •
edited
Loading

Seems like I scrwd something. Shall I delete this branch and PR once again?

@sfmqrb
Copy link

sfmqrb commented Dec 8, 2023 •
edited
Loading

Hello @tansy @inikep,
When will this PR be merged?
Also, if I update a compression package and create a PR, you need to benchmark it yourself to update the README file, correct?
I guess what I'm asking is, what is the contribution process? Do contributors only update a compression package and make sure everything is in place, or do they need to update the README file with new benchmark results too?

@tansy
Copy link
Collaborator Author

tansy commented Dec 21, 2023

When will this PR be merged?

Don't know. Me think it won't happen.
It seems to be abandoned by original creator, and "mod", who could accept it, is absent either.

@inikep inikep changed the base branch from master to testing January 10, 2025 14:44
@inikep inikep merged commit 3910a77 into inikep:testing Jan 10, 2025
1 check was pending
@inikep
Copy link
Owner

inikep commented Jan 10, 2025

lzbench 2.0 will add support for Libdeflate v1.23 (based on this PR) soon.

@tansy
Copy link
Collaborator Author

tansy commented Jan 20, 2025

So this branch can be deleted, aye?

@inikep
Copy link
Owner

inikep commented Jan 21, 2025

Yes, I squashed you commits and ported to https://github.com/inikep/lzbench/commits/update

@tansy tansy deleted the libdeflate-1.19 branch January 21, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tansy @sfmqrb @inikep