Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ppmd based on LZMA SDK 22.01 (thanks to @pps83) #121

Closed
wants to merge 1 commit into from

Conversation

pps83
Copy link

@pps83 pps83 commented Jan 11, 2023

No description provided.

@pps83
Copy link
Author

pps83 commented Jan 11, 2023

sounds stupid to say thanks to @myself, I simply based entire PR on some other diff that added another codec

@tansy
Copy link
Collaborator

tansy commented Oct 14, 2023

All those functions ( pmalloc(), pfree(), CharWriter, CharWriterFunc() ) should be moved to lzbench_ppmd_compress(). They are small enough to move to the function body. Compressors.cpp is not private yard, it's public space and you should not litter it.

@pps83
Copy link
Author

pps83 commented Dec 21, 2023

@tansy sorry for late reply. PR updated.

@pps83 pps83 changed the title Add ppmd based on LZMA SDK 22.01 (thanks to @pps83) Add ppmd based on LZMA SDK 23.01 (thanks to @pps83) Dec 21, 2023
@pps83 pps83 changed the title Add ppmd based on LZMA SDK 23.01 (thanks to @pps83) Add ppmd based on LZMA SDK 22.01 (thanks to @pps83) Dec 22, 2023
@pps83
Copy link
Author

pps83 commented Dec 22, 2023

FYI, when I tried to use latest LZMA SDK 23.01 (instead of 22.01) I got compilation errors because lzbench already contains older lzma sdk parts (specifically 7zTypes.h, Compiler.h, Precomp.h and others are conflicting). With 22.01 at least it compiles cleanly.

when lzma is updated to 23.01, libppmd should also be updated to 23.01 at the same time

FYI @inikep

@inikep inikep changed the base branch from master to testing January 10, 2025 19:40
@inikep
Copy link
Owner

inikep commented Jan 10, 2025

I cherry picked your commit to solve the conflicts. lzbench 2.0 will add support for ppmd soon.

@inikep inikep closed this Jan 10, 2025
@pps83
Copy link
Author

pps83 commented Jan 11, 2025

Perhaps, would be good to update to latest 7zip/lzma sdk: https://7-zip.org/sdk.html (it's 24.09 now)

@inikep
Copy link
Owner

inikep commented Jan 13, 2025

I tried lzma 24.09 but it doesn't work with ppmd based on LZMA SDK 23.01.
So in the next lzbench version we will have:

  • ppmd based on LZMA SDK 23.01 (thanks to @pps83)
  • lzma 23.01

@pps83
Copy link
Author

pps83 commented Jan 13, 2025

you need to take both lzma sdk 24.09 and updated lib ppmd (I updated my libppmd fork with 24.09, works for me)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants