-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ppmd based on LZMA SDK 22.01 (thanks to @pps83) #121
Conversation
sounds stupid to say |
All those functions ( pmalloc(), pfree(), CharWriter, CharWriterFunc() ) should be moved to |
@tansy sorry for late reply. PR updated. |
FYI, when I tried to use latest LZMA SDK 23.01 (instead of 22.01) I got compilation errors because lzbench already contains older lzma sdk parts (specifically 7zTypes.h, Compiler.h, Precomp.h and others are conflicting). With 22.01 at least it compiles cleanly. when lzma is updated to 23.01, libppmd should also be updated to 23.01 at the same time FYI @inikep |
I cherry picked your commit to solve the conflicts. lzbench 2.0 will add support for ppmd soon. |
Perhaps, would be good to update to latest 7zip/lzma sdk: https://7-zip.org/sdk.html (it's 24.09 now) |
I tried lzma 24.09 but it doesn't work with ppmd based on LZMA SDK 23.01.
|
you need to take both lzma sdk 24.09 and updated lib ppmd (I updated my libppmd fork with 24.09, works for me) |
No description provided.