Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX]: Add nodejs setup for release script #690

Merged
merged 6 commits into from
Dec 11, 2024
Merged

[FIX]: Add nodejs setup for release script #690

merged 6 commits into from
Dec 11, 2024

Conversation

jeremyfelder
Copy link
Collaborator

Describe the changes

This PR:

  • Fixes the release script by ensuring nodejs is installed before trying to bump the docs version
  • Moves building docker images for releases into a separate workflow as they only need to be rebuilt if prerequisite packages change
  • Updates the release workflow and the build_all script to pull and use the latest docker images

@jeremyfelder jeremyfelder merged commit eeceb6c into main Dec 11, 2024
29 checks passed
@jeremyfelder jeremyfelder deleted the fix-release-script branch December 11, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeonHibnik LeonHibnik LeonHibnik approved these changes

@yshekel yshekel yshekel approved these changes

@ShaniBabayoff ShaniBabayoff Awaiting requested review from ShaniBabayoff

@aviadingo aviadingo Awaiting requested review from aviadingo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeremyfelder @yshekel @LeonHibnik