Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Poseidon2 hash function #673

Merged
merged 33 commits into from
Dec 5, 2024
Merged

feat: Poseidon2 hash function #673

merged 33 commits into from
Dec 5, 2024

Conversation

danny-shterman
Copy link
Contributor

@danny-shterman danny-shterman commented Dec 3, 2024 •
edited by yshekel
Loading

  • Some values of t not supported at this moment for large fields (>4B).
  • Sponge hash no supported

cuda-backend-branch: danny_poseidon2/v3.2

LeonHibnik
LeonHibnik reviewed Dec 3, 2024
View reviewed changes
icicle/run.log.cpu_works Outdated Show resolved Hide resolved
icicle/tests/test_hash_api.cpp Outdated Show resolved Hide resolved
icicle/include/icicle/hash/poseidon2_constants/constants/goldilocks_poseidon2.h Outdated Show resolved Hide resolved
1. Fix Leon's comments
9267c00 
2. Add documentation
3. Fix clang-format issues
@yshekel yshekel changed the title Danny poseidon2/v3.2 feat: Poseidon2 hash function Dec 5, 2024
@yshekel yshekel merged commit da890c7 into main Dec 5, 2024
30 checks passed
@yshekel yshekel deleted the danny_poseidon2/v3.2 branch December 5, 2024 20:15
mickeyasa pushed a commit that referenced this pull request Dec 8, 2024
@danny-shterman @LeonHibnik
@yshekel @mickeyasa
feat: Poseidon2 hash function (#673)
3010b1a 
- Lacks support for sponge hash
- Lacks support for t>4 cases for large fields (>4B)

Co-authored-by: danny-shterman <[email protected]>
Co-authored-by: Leon Hibnik <[email protected]>
Co-authored-by: LeonHibnik <[email protected]>
Co-authored-by: Yuval Shekel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeonHibnik LeonHibnik LeonHibnik approved these changes

@yshekel yshekel yshekel approved these changes

@mickeyasa mickeyasa Awaiting requested review from mickeyasa

@krakhit krakhit Awaiting requested review from krakhit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danny-shterman @yshekel @LeonHibnik