-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Montgomery representation #663
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Koren-Brand <[email protected]>
…ation as well Signed-off-by: Koren-Brand <[email protected]>
…ar/switch-to-mont
Signed-off-by: Koren-Brand <[email protected]>
icicle/tests/test_curve_api.cpp
Outdated
} | ||
END_TIMER(ref, "scalar mult double-and-add", true); | ||
|
||
ASSERT_EQ(mult, expected_mult); | ||
} | ||
|
||
TYPED_TEST(CurveSanity, ECarith) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yshekel keep these tests or remove?
END_TIMER(u64Mult_asm, "U64-MULT-asm", true); | ||
} | ||
|
||
#ifndef BARRET |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
keep this test? @Koren-Brand
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it can be deleted according to @yshekel it is a test for an x86 implementation that he didn't complete
…t' into hadar/switch-to-mont
…t' into hadar/switch-to-mont
Signed-off-by: Koren-Brand <[email protected]>
8b2aa98
to
a880d5d
Compare
This PR changes the basic field multiplier to be the Montgomery modular multiplier. This means that the Field class now assumes Montgomery as the default representation of elements.
cuda-backend-branch: hadar/gpu_mont_mult