Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Montgomery representation #663

Open
wants to merge 62 commits into
base: main
Choose a base branch
from

Conversation

HadarIngonyama
Copy link
Contributor

@HadarIngonyama HadarIngonyama commented Nov 21, 2024

This PR changes the basic field multiplier to be the Montgomery modular multiplier. This means that the Field class now assumes Montgomery as the default representation of elements.

cuda-backend-branch: hadar/gpu_mont_mult

}
END_TIMER(ref, "scalar mult double-and-add", true);

ASSERT_EQ(mult, expected_mult);
}

TYPED_TEST(CurveSanity, ECarith)
Copy link
Contributor Author

@HadarIngonyama HadarIngonyama Nov 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yshekel keep these tests or remove?

END_TIMER(u64Mult_asm, "U64-MULT-asm", true);
}

#ifndef BARRET
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keep this test? @Koren-Brand

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it can be deleted according to @yshekel it is a test for an x86 implementation that he didn't complete

@jeremyfelder jeremyfelder force-pushed the hadar/switch-to-mont branch 2 times, most recently from 8b2aa98 to a880d5d Compare December 10, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants