Add FRI folding for M31 #618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…are ok, but data transfer takes a long time compared to test sizes
yshekel
reviewed
Sep 24, 2024
yshekel
reviewed
Sep 24, 2024
yshekel
reviewed
Sep 24, 2024
yshekel
reviewed
Sep 24, 2024
yshekel
approved these changes
Sep 24, 2024
@yshekel These hard coded values are taken from Stwo's unit tests and are deterministic values. I can change the tests to use Stwo's crate to generate all of these values instead of using the hardcoded ones (though they will be the same). is that what you mean? |
ChickenLover
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds FRI folding for M31 field.