-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Devmode to Reduce compilation time (including G2 and ECNTT) #395
Devmode to Reduce compilation time (including G2 and ECNTT) #395
Conversation
If we just disable the mixed-radix EC NTT and only use radix-2, would that give a further significant speedup? |
umm - like still ~80% compilation time it's msm.cu g2 - also weird C++ gtests fail but rust all passing, and didn't expect that |
I don't think mixed-radix NTT is compiled for ECNTT here since it's not instantiated. |
…at/reduce-build-time
oh right - I forgot to also push merged e1ff687 I tested locally |
…at/reduce-build-time
…at/reduce-build-time
This reverts commit d7151b5.
…at/reduce-build-time
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think 163 minutes was when building ECNTT for mix-radix algorithm so I am not sure this is the case.
Can you locally build it with and without devmode for a specific curve and tell the difference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on the answers. Note that I wrote a minor comment about the commented mixed-radix ECTT. You can ignore it if you want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO add devmode to golang
devmode to reduce compilation time
devmode to reduce compilation time
Describe the changes
Introduces 'develop' mode - with reduced -O0 optimizations instead of -O3 and disabled inlining and loop unrolling
with slightly lower performance but much reduced build time (6 minutes vs reported 163 minutes on i9 13900K? for all curves)
Linked Issues
Resolves #316