Poseidon - update with new release #10
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImmanuelSegol
commented
May 9, 2023
ImmanuelSegol
commented
May 11, 2023
ImmanuelSegol
commented
May 11, 2023
ImmanuelSegol
commented
May 11, 2023
ImmanuelSegol
commented
May 11, 2023
tests/integration_poseidon.rs
Outdated
Comment on lines
193
to
194
| // shouldnt panic at unwrap | ||
| //poseidon.log_api_values(); |
There was a problem hiding this comment.
Suggested change
| // shouldnt panic at unwrap | |
| //poseidon.log_api_values(); |
ImmanuelSegol
commented
May 11, 2023
ImmanuelSegol
commented
May 11, 2023
tests/integration_poseidon.rs
Outdated
| for _ in 0..11 { | ||
| let _ = poseidon.set_data(scalar.as_slice()); | ||
| } | ||
| const BUFFER_SIZE: usize = 999999968; // 1GB MB // 256mb |
There was a problem hiding this comment.
Suggested change
| const BUFFER_SIZE: usize = 999999968; // 1GB MB // 256mb | |
| const BUFFER_SIZE: usize = 999999968; // 1GB |
ImmanuelSegol
commented
May 11, 2023
jeremyfelder
requested changes
May 11, 2023
| @@ -31,6 +33,11 @@ pub struct PoseidonResult { | |||
| pub layer_id: u32, | |||
| } | |||
|
|
|||
| pub struct PoseidonReadResult<'a> { | |||
| pub expected_result: usize, | |||
There was a problem hiding this comment.
This is the size of the result and not the actual expected result?
There was a problem hiding this comment.
Should this file be moved to the driver_client folder since it more specific to the HW integration than the primitive itself?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.