Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding props.onClose() on transfer, deposit, withdraw modals #270

Merged
merged 2 commits into from
Oct 21, 2024
Merged

Adding props.onClose() on transfer, deposit, withdraw modals #270

merged 2 commits into from
Oct 21, 2024

Conversation

dusterbloom
Copy link
Contributor

This PR adds a simple props.onClose() to close the modals after success

@dusterbloom dusterbloom added the enhancement New feature or request label Oct 21, 2024
@dusterbloom dusterbloom self-assigned this Oct 21, 2024
@dusterbloom dusterbloom linked an issue Oct 21, 2024 that may be closed by this pull request
transfers/frontend: transact modals stay open even after completion #224
Closed
@dusterbloom dusterbloom marked this pull request as ready for review October 21, 2024 13:34
juanenrisley
juanenrisley approved these changes Oct 21, 2024
View reviewed changes
Copy link
Contributor

@juanenrisley juanenrisley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏿

@davekaj davekaj merged commit 50bf4be into main Oct 21, 2024
2 checks passed
@davekaj davekaj deleted the dusterbloom/fix-front-end-close-modal branch October 21, 2024 15:41
hu55a1n1 pushed a commit that referenced this pull request Oct 21, 2024
@dusterbloom @hu55a1n1
Adding props.onClose() on transfer, deposit, withdraw modals (#270)
1e6ffa7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanenrisley juanenrisley juanenrisley approved these changes

Assignees

@dusterbloom dusterbloom

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

transfers/frontend: transact modals stay open even after completion
3 participants
@dusterbloom @juanenrisley @davekaj