-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run transfers app E2E tests in an Action, and backend with docker compose #203
Conversation
Before merging:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So it works, I tried to run it locally, but it wouldn't work on my M1 mac, and the issue was related to this, it seems it is only working on the linux CI.
We should fix this so docker compose should work regardless of either platform, or at least give different insturctions locally (sometimes you can pass a flag that will allow you to build on a different platform)
Can you guys look into this before we merge? Otherwise, it seems to be working
@davekaj I would not bother too much with issues about docker compose with M1. Just because the quartz cli docker image is temporary. We need to create a new one once the repo and all that stuff are published. |
Until #79 is completed, a diff (
remove_mtcs_from_workspace.diff
) is applied to remove the mtcs dependencies.Closes #144