Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run transfers app E2E tests in an Action, and backend with docker compose #203

Merged
merged 56 commits into from
Oct 1, 2024

Conversation

llunaCreixent
Copy link
Contributor

@llunaCreixent llunaCreixent commented Sep 13, 2024

  • successful deployment with Dockerfile and docker-compose
  • run tests in CI
  • improve cli Dockerfile - we will do this after the repo is public and we can publish the docker images
  • formatting files

Until #79 is completed, a diff (remove_mtcs_from_workspace.diff) is applied to remove the mtcs dependencies.

Closes #144

@llunaCreixent llunaCreixent self-assigned this Sep 13, 2024
@juanenrisley juanenrisley marked this pull request as ready for review October 1, 2024 10:41
@llunaCreixent llunaCreixent changed the title WIP First docker compose setup and docker image for CLI Run transfers app E2E tests in an Action, and run wasmd node and enclave with docker compose Oct 1, 2024
@llunaCreixent llunaCreixent changed the title Run transfers app E2E tests in an Action, and run wasmd node and enclave with docker compose Run transfers app E2E tests in an Action, and backend with docker compose Oct 1, 2024
@llunaCreixent
Copy link
Contributor Author

llunaCreixent commented Oct 1, 2024

Before merging:

  • make sure the crates paths are correct in config
  • clean Dockerfile

crates/cli/Dockerfile Outdated Show resolved Hide resolved
Copy link
Contributor

@davekaj davekaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it works, I tried to run it locally, but it wouldn't work on my M1 mac, and the issue was related to this, it seems it is only working on the linux CI.

We should fix this so docker compose should work regardless of either platform, or at least give different insturctions locally (sometimes you can pass a flag that will allow you to build on a different platform)

Can you guys look into this before we merge? Otherwise, it seems to be working

@juanenrisley
Copy link
Contributor

@davekaj I would not bother too much with issues about docker compose with M1. Just because the quartz cli docker image is temporary. We need to create a new one once the repo and all that stuff are published.

@davekaj davekaj merged commit 9ecc02f into main Oct 1, 2024
9 checks passed
@davekaj davekaj deleted the juanenrisley/144-ci-e2e-with-mocked-sgx branch October 1, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Continuous Integration: Simple happy path E2E tests with mocked SGX
3 participants