IPAM Host Support for Bloxone Ansible v2 #52
Conversation
VishrutiBuddhadev
commented
Dec 10, 2024
VishrutiBuddhadev
commented
- Generated resources for ipam_host
- Written integration tests
- deprecate b1_ipam_host and b1_ipam_host_gather
VishrutiBuddhadev
changed the title
VishrutiBuddhadev
changed the title
unasra
changed the title
plugins/modules/ipam_host.py
Outdated
| """ # noqa: E501 | ||
|
|
||
| EXAMPLES = r""" | ||
| - name: "Create a Host" |
There was a problem hiding this comment.
The spacing in the EXAMPLES isnt aligned with other part of doc
plugins/modules/ipam_host.py
Outdated
| state: "present" | ||
| register: ip_space | ||
|
|
||
| - name: "Create a Subnet" |
There was a problem hiding this comment.
Why is subnet required here ?
There was a problem hiding this comment.
To create a host with addresses both IP Space and Subnet are required. So I have added it to examples
There was a problem hiding this comment.
But there isnt any usage of subnet in any of the tasks !
There was a problem hiding this comment.
If I don't create a subnet, it gives this error No existing Subnet to contain 10.0.0.1 IP Address
plugins/modules/ipam_host.py
Outdated
| state: "present" | ||
| register: host | ||
|
|
||
| - name: "Create an IP space" |
There was a problem hiding this comment.
Create IP Space at the beginning of the examples with (required as parent) specified in the name
plugins/modules/ipam_host.py
Outdated
| state: "present" | ||
| register: subnet | ||
|
|
||
| - name: "Create a Host with Addresses" |
There was a problem hiding this comment.
| - name: "Create a Host with Addresses" | |
| - name: "Create a Host with Additional Fields" |
plugins/modules/ipam_host.py
Outdated
|
|
||
| - name: "Create an IP space" | ||
| infoblox.bloxone.ipam_ip_space: | ||
| name: "{{ name }}" |
There was a problem hiding this comment.
| name: "{{ name }}" | |
| name: "example_host" |
plugins/modules/ipam_host_info.py
Outdated
| infoblox.bloxone.ipam_host: | ||
| name: "{{ name }}" | ||
| tags: | ||
| tag1: "{{ tag1_value }}" |
There was a problem hiding this comment.
Provide an actual tag value and not a placeholder
| tag2: "value2" | ||
| state: "present" | ||
| register: host | ||
|
|
| - host_info.objects[0].tags.tag1 == "value1" | ||
| - host_info.objects[0].tags.tag2 == "value2" | ||
|
|
||
| - name: Create an IP space |
There was a problem hiding this comment.
Use setup_ip_space and setup_subnet instead of creating them here .
| space: "{{ ip_space.id }}" | ||
| state: "present" | ||
| register: host | ||
|
|
There was a problem hiding this comment.
Remove this line . Keep lines only between different plays !
plugins/modules/ipam_host_info.py
Outdated
| """ # noqa: E501 | ||
|
|
||
| EXAMPLES = r""" | ||
| - name: Create a Host |
There was a problem hiding this comment.
This block can be removed , no need to create the host , host.id can be used as a placeholder in the GET Calls below !
plugins/modules/ipam_host_info.py
Outdated
| infoblox.bloxone.ipam_host_info: | ||
| id: "{{ host.id }}" | ||
| register: host_info | ||
| - assert: |
There was a problem hiding this comment.
Assertions aren't required in examples.
| --- | ||
| dependencies: | ||
| - setup_ip_space | ||
| - setup_subnet |
There was a problem hiding this comment.
Add a Line at the end of the file
| @@ -0,0 +1,4 @@ | |||
| --- | |||
| dependencies: | |||
There was a problem hiding this comment.
Make Dependencies a list instead.
| dependencies: | |
| dependencies: [ setup_ip_space , setup_subnet ] |
| name: "{{ name }}" | ||
| state: "present" | ||
| check_mode: true | ||
| register: host |
There was a problem hiding this comment.
Info Call and assertion statements are missing here.
