-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DNS server Support for Bloxone Ansible v2 #49
base: v2
Are you sure you want to change the base?
Conversation
elements: dict | ||
suboptions: | ||
algorithm: | ||
description: "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add description to all the algorithm fields.
- address: "192.168.11.11" | ||
fqdn: "example.com." | ||
tags: | ||
location: "my-location" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
location: "my-location" | |
location: "site-1" |
infoblox.bloxone.dns_server_info: | ||
id: "{{ dns_server_id }}" | ||
|
||
- name: Get DNS Server information by filters (e.g., name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- name: Get DNS Server information by filters (e.g., name) | |
- name: Get DNS Server information by filters (e.g. name) |
- dns_server_info.objects[0].id == dns_server.id | ||
- dns_server_info.objects[0].add_edns_option_in_outgoing_query == true | ||
|
||
- name: Create a DNS Server with auto_sort_views enabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- name: Create a DNS Server with auto_sort_views enabled | |
- name: Create a DNS Server with Auto Sort Views enabled |
- name: Create a DNS Server with Custom Root Nameservers | ||
infoblox.bloxone.dns_server: | ||
name: "{{ dns_server_name }}" | ||
custom_root_ns: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add multiple name servers here ?
- dns_server_info is not failed | ||
- dns_server_info.objects | length == 1 | ||
- dns_server_info.objects[0].recursion_enabled == true | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing UT for recursive_clients
attribute.
- dns_server_info.objects | length == 1 | ||
- dns_server_info.objects[0].recursion_enabled == true | ||
|
||
- name: Create a DNS server with resolver_query_timeout set to 15 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please you modify all the task names to include attribute names in Capital case and not snake case and remove the value of the attribute .
- dns_server_info.objects | length == 1 | ||
- dns_server_info.objects[0].secondary_soa_query_limit == 2 | ||
|
||
- name: Create a DNS server with sort_list configuration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you test any
value for the element in sort list ?
state: present | ||
register: dns_server | ||
|
||
- name: Get Information about the DNS Server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- name: Get Information about the DNS Server | |
- name: Get Information about the DNS Server by filter (name) |
infoblox.bloxone.dns_server: | ||
name: "{{ dns_server_name }}" | ||
state: "absent" | ||
ignore_errors: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a new line at the end of file
Sanity - passed
integration - passed
lint check - passed