Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS server Support for Bloxone Ansible v2 #49

Open
wants to merge 3 commits into
base: v2
Choose a base branch
from

Conversation

AnilGadiyarHJ
Copy link
Collaborator

Sanity - passed
integration - passed
lint check - passed

@AnilGadiyarHJ AnilGadiyarHJ requested a review from unasra December 11, 2024 16:00
elements: dict
suboptions:
algorithm:
description: ""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add description to all the algorithm fields.

- address: "192.168.11.11"
fqdn: "example.com."
tags:
location: "my-location"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
location: "my-location"
location: "site-1"

infoblox.bloxone.dns_server_info:
id: "{{ dns_server_id }}"

- name: Get DNS Server information by filters (e.g., name)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Get DNS Server information by filters (e.g., name)
- name: Get DNS Server information by filters (e.g. name)

- dns_server_info.objects[0].id == dns_server.id
- dns_server_info.objects[0].add_edns_option_in_outgoing_query == true

- name: Create a DNS Server with auto_sort_views enabled
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Create a DNS Server with auto_sort_views enabled
- name: Create a DNS Server with Auto Sort Views enabled

- name: Create a DNS Server with Custom Root Nameservers
infoblox.bloxone.dns_server:
name: "{{ dns_server_name }}"
custom_root_ns:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add multiple name servers here ?

- dns_server_info is not failed
- dns_server_info.objects | length == 1
- dns_server_info.objects[0].recursion_enabled == true

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing UT for recursive_clients attribute.

- dns_server_info.objects | length == 1
- dns_server_info.objects[0].recursion_enabled == true

- name: Create a DNS server with resolver_query_timeout set to 15
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please you modify all the task names to include attribute names in Capital case and not snake case and remove the value of the attribute .

- dns_server_info.objects | length == 1
- dns_server_info.objects[0].secondary_soa_query_limit == 2

- name: Create a DNS server with sort_list configuration
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you test any value for the element in sort list ?

state: present
register: dns_server

- name: Get Information about the DNS Server
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Get Information about the DNS Server
- name: Get Information about the DNS Server by filter (name)

infoblox.bloxone.dns_server:
name: "{{ dns_server_name }}"
state: "absent"
ignore_errors: true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a new line at the end of file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants