-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(linters): Enable usetesting
linter
#16456
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @zak-pawel! Just one suggestion...
logger/structured_logger_test.go
Outdated
// t.TempDir() doesn't work properly on windows for this case | ||
//nolint:usetesting // "os.CreateTemp("", ...) could be replaced by os.CreateTemp(t.TempDir(), ...) in TestStructuredFile" | ||
tmpfile, err := os.CreateTemp("", "") | ||
require.NoError(t, err) | ||
defer os.Remove(tmpfile.Name()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm how about
// t.TempDir() doesn't work properly on windows for this case | |
//nolint:usetesting // "os.CreateTemp("", ...) could be replaced by os.CreateTemp(t.TempDir(), ...) in TestStructuredFile" | |
tmpfile, err := os.CreateTemp("", "") | |
require.NoError(t, err) | |
defer os.Remove(tmpfile.Name()) | |
tmpfile := filepath.Join(t.TempDir(), "test.log") |
of course including the changes for the parameters... Same for the instances below.
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
Summary
In this PR, I'm enabling
usetesting
linter and addressing following findings:Checklist
Related issues
resolves #16412