Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Fix linter findings for revive:comment-spacings (part 1) #15896

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

zak-pawel
Copy link
Collaborator

Summary

Address findings for revive:comment-spacings in:

- cmd/telegraf/...
- config/...
- internal/...
- logger/...
- models/...
- plugins/aggregators/...
- plugins/common/...
- plugins/parsers/...
- plugins/processors/...
- plugins/serializers/...
- tools/...

It is only part of the bigger job (for issue: #15806).
After all findings of this type in whole project are handled, we can enable revive:comment-spacings rule in golangci-lint.

Checklist

  • No AI generated code was used in this PR

@zak-pawel zak-pawel changed the title chore: Fix linter findings for revive:comment-spacings (part 1)) chore: Fix linter findings for revive:comment-spacings (part 1) Sep 16, 2024
@telegraf-tiger telegraf-tiger bot added the chore label Sep 16, 2024
@DStrand1 DStrand1 removed their assignment Sep 16, 2024
@DStrand1 DStrand1 added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Sep 16, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zak-pawel!

@srebhan srebhan merged commit 43590ca into influxdata:master Sep 19, 2024
29 checks passed
@github-actions github-actions bot added this to the v1.32.1 milestone Sep 19, 2024
srebhan pushed a commit that referenced this pull request Oct 7, 2024
asaharn pushed a commit to asaharn/telegraf that referenced this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore linter ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants