Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(testutil): Fix value comparison #15886

Merged

Conversation

LarsStegman
Copy link
Contributor

Summary

One of my tests failed, but it was because the comparison function for test cmp opts didn't work properly

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #15885

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Sep 15, 2024
@LarsStegman LarsStegman force-pushed the fix/testutil-metric-lessthanvalue branch from d6f47d8 to f62e5c0 Compare September 15, 2024 13:31
@srebhan srebhan changed the title fix(test): fix metricDiff.lessThan value comparision test(testutil): Fix value comparison Sep 16, 2024
@telegraf-tiger telegraf-tiger bot added the test label Sep 16, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LarsStegman! I wonder why this went unnoticed for so long...

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Sep 16, 2024
@DStrand1 DStrand1 merged commit 65999bd into influxdata:master Sep 16, 2024
29 checks passed
@github-actions github-actions bot added this to the v1.32.1 milestone Sep 16, 2024
@LarsStegman
Copy link
Contributor Author

Thanks @LarsStegman! I wonder why this went unnoticed for so long...

Yeah I was really surprised to see it's been in there since 2019 😂

srebhan pushed a commit that referenced this pull request Oct 7, 2024
asaharn pushed a commit to asaharn/telegraf that referenced this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(testutil): metricDiff lessFunc does not compare single field metric properly
3 participants