chore(linters): Enable import-alias-naming and redundant-import-alias rules for revive
#15836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ias` rules for revive
…ias` rules for revive
srebhan
reviewed
Sep 4, 2024
There was a problem hiding this comment.
Thanks a lot for this epic effort @zak-pawel! I do have some comments in the code, but in general there are two things
- How about fixing variable naming instead of using an alias e.g. for
github.com/influxdata/telegraf/config? The variable can easily be namedcfgwithout issues... - I love your consistent aliases for internal things like
common_tls,internal_whateveretc. but you deviate forinflux_serializer,influx_parserorjsonparser. How about also following the pattern and useserializers_influx,parsers_influxandparsers_jsoninstead?
plugins/outputs/azure_data_explorer/azure_data_explorer_test.go
Outdated
Show resolved
Hide resolved
Hipska
suggested changes
Sep 4, 2024
plugins/outputs/azure_data_explorer/azure_data_explorer_test.go
Outdated
Show resolved
Hide resolved
Hipska
suggested changes
Sep 4, 2024
Hipska
approved these changes
Sep 4, 2024
srebhan
reviewed
Sep 5, 2024
There was a problem hiding this comment.
Thanks @zak-pawel! Just two more comments and I think we are good...
Hipska
approved these changes
Sep 5, 2024
srebhan
approved these changes
Sep 5, 2024
srebhan
added
the
ready for final review
…as-naming_redundant-import-alias # Conflicts: # plugins/outputs/exec/exec_test.go # plugins/outputs/prometheus_client/v1/collector.go # plugins/outputs/prometheus_client/v2/collector.go
Hipska
approved these changes
Sep 12, 2024
…as-naming_redundant-import-alias # Conflicts: # plugins/inputs/logstash/logstash.go
srebhan
approved these changes
Sep 13, 2024
Hipska
approved these changes
Sep 13, 2024
…as-naming_redundant-import-alias # Conflicts: # plugins/inputs/aerospike/aerospike.go # plugins/inputs/gnmi/gnmi.go
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Related issues
resolves #15820
resolves #15825