feat(inputs.aerospike): Add latency info #15578

ajiraj2411 · 2024-06-29T16:54:24Z

Summary

Opening a feature request for Telegraf Aerospike Plugin with Latency Info

Checklist

No AI generated code was used in this PR

Related issues

resolves #15579 which is duplicate of 4665

DStrand1

Thanks for the contribution! I see there's a linter issue still present, could you resolve that and my preliminary comments? Thanks!

plugins/inputs/aerospike/aerospike.go

telegraf-tiger · 2024-07-23T18:09:43Z

Hello! I am closing this issue due to inactivity. I hope you were able to resolve your problem, if not please try posting this question in our Community Slack or Community Forums or provide additional details in this issue and reqeust that it be re-opened. Thank you!

powersj · 2024-07-24T19:21:29Z

Hi,

Would be happy to circle back around on this PR after the above changes are made. Thanks!

telegraf-tiger · 2024-08-12T18:09:42Z

Hello! I am closing this issue due to inactivity. I hope you were able to resolve your problem, if not please try posting this question in our Community Slack or Community Forums or provide additional details in this issue and reqeust that it be re-opened. Thank you!

ajiraj2411 · 2024-09-01T13:39:49Z

@powersj Can you please re-open the PR? I've addressed the review comments.

cc: @srebhan @DStrand1

DStrand1

Thanks for making the changes!

srebhan · 2024-09-05T19:08:30Z

@ajiraj2411 could you please fix the failing integration test which complains about "command latency not registered". This makes me think if your change won't break the plugin with older versions of the aerospike server? If so, please add a flag to the configuration to manually enable gathering the latency!

ajiraj2411 · 2024-09-05T19:57:00Z

@srebhan As per the doc - https://aerospike.com/docs/server/reference/info?version=7&all=true#latencies, this configuration available from 5.1.

All enabled benchmarks can be tracked in Database 5.1 and later. Versions prior to 5.1 track only the auto-enabled benchmarks through the info protocol.

Can you please help me with this? We can connect if you want tomorrow.

plugins/inputs/aerospike/aerospike.go

telegraf-tiger · 2024-09-09T19:36:07Z

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

🥳 This pull request decreases the Telegraf binary size by -6.47 % for linux amd64 (new size: 243.8 MB, nightly size 260.6 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB	RPM	TAR GZ	ZIP
amd64.deb	aarch64.rpm	darwin_amd64.tar.gz	windows_amd64.zip
arm64.deb	armel.rpm	darwin_arm64.tar.gz	windows_arm64.zip
armel.deb	armv6hl.rpm	freebsd_amd64.tar.gz	windows_i386.zip
armhf.deb	i386.rpm	freebsd_armv7.tar.gz
i386.deb	ppc64le.rpm	freebsd_i386.tar.gz
mips.deb	riscv64.rpm	linux_amd64.tar.gz
mipsel.deb	s390x.rpm	linux_arm64.tar.gz
ppc64el.deb	x86_64.rpm	linux_armel.tar.gz
riscv64.deb		linux_armhf.tar.gz
s390x.deb		linux_i386.tar.gz
		linux_mips.tar.gz
		linux_mipsel.tar.gz
		linux_ppc64le.tar.gz
		linux_riscv64.tar.gz
		linux_s390x.tar.gz

srebhan

@ajiraj2411 thanks for your update! Some more small comments but we are close. Can I ask you for a favor? Could you please add an integration test with a newer version of an Aerospike container and actually collect the latency metric!? You should be able to copy and adapt the existing test.

plugins/inputs/aerospike/sample.conf

plugins/inputs/aerospike/aerospike_test.go

plugins/inputs/aerospike/aerospike.go

srebhan · 2024-09-11T10:53:09Z

plugins/inputs/aerospike/aerospike.go

+	startTime, _ := time.Parse(time.TimeOnly, sTime)
+	endTime, _ := time.Parse(time.TimeOnly, eTime)


Please check the returned errors as otherwise we may get strange results if the data provided by the API changes format or contains invalid values!

srebhan · 2024-09-11T10:53:53Z

plugins/inputs/aerospike/aerospike_test.go

+	tests := []struct {
+		name string
+		args args
+		want float64


Please name the variable expected.

srebhan · 2024-09-11T10:54:13Z

plugins/inputs/aerospike/aerospike_test.go

+			if got := getDurationOfTransaction(tt.args.sTimeWithTimeZone, tt.args.eTime); got != tt.want {
+				t.Errorf("getDurationOfTransaction() = %v, want %v", got, tt.want)
+			}


Please use the corresponding require.Equal function!

telegraf-tiger · 2024-09-30T18:09:41Z

Hello! I am closing this issue due to inactivity. I hope you were able to resolve your problem, if not please try posting this question in our Community Slack or Community Forums or provide additional details in this issue and reqeust that it be re-opened. Thank you!

ajiraj2411 mentioned this pull request Jun 29, 2024

Telegraf Aerospike Plugin with Latency Info #4736

Closed

3 tasks

ajiraj2411 force-pushed the master branch from d86ac12 to 6186cf2 Compare June 29, 2024 17:00

feat: Aerospike input plugin with latency info

271bbc6

ajiraj2411 force-pushed the master branch from 6186cf2 to 271bbc6 Compare June 29, 2024 17:09

Fixed unit test

7e0c1dc

ajiraj2411 changed the title ~~Aerospike input plugin with latency info~~ feat: Aerospike input plugin with latency info Jun 29, 2024

telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jun 29, 2024

Lint fix for line length

7e723c3

DStrand1 reviewed Jul 1, 2024

View reviewed changes

plugins/inputs/aerospike/aerospike.go Outdated Show resolved Hide resolved

plugins/inputs/aerospike/aerospike.go Show resolved Hide resolved

plugins/inputs/aerospike/aerospike.go Outdated Show resolved Hide resolved

plugins/inputs/aerospike/aerospike.go Outdated Show resolved Hide resolved

DStrand1 self-assigned this Jul 1, 2024

DStrand1 changed the title ~~feat: Aerospike input plugin with latency info~~ feat(inputs.aerospike): Add latency info Jul 1, 2024

telegraf-tiger bot added the plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins label Jul 1, 2024

powersj added the waiting for response waiting for response from contributor label Jul 8, 2024

telegraf-tiger bot closed this Jul 23, 2024

telegraf-tiger bot removed the waiting for response waiting for response from contributor label Jul 24, 2024

srebhan mentioned this pull request Jul 29, 2024

Telegraf Aerospike Plugin with Latency Info #15579

Open

powersj reopened this Jul 29, 2024

powersj added the waiting for response waiting for response from contributor label Jul 29, 2024

telegraf-tiger bot closed this Aug 12, 2024

Addressed review comments

e60513b

telegraf-tiger bot removed the waiting for response waiting for response from contributor label Sep 1, 2024

srebhan reopened this Sep 3, 2024

go file formating using gofmt

3be571f

ajiraj2411 requested a review from DStrand1 September 3, 2024 07:47

ns-arajendran added 2 commits September 3, 2024 13:30

floating parse logic to change the float64 instead of float32

b9973dd

Renamed function TestParseLatencyInfo properly

a977c55

Addressed the ci test failure

3094ca0

DStrand1 approved these changes Sep 5, 2024

View reviewed changes

DStrand1 assigned srebhan and unassigned DStrand1 Sep 5, 2024

DStrand1 added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Sep 5, 2024

srebhan reviewed Sep 9, 2024

View reviewed changes

plugins/inputs/aerospike/aerospike.go Outdated Show resolved Hide resolved

Using flag for latency info gather in Aerospike

44b4eee

ajiraj2411 force-pushed the master branch from 7c39046 to 44b4eee Compare September 9, 2024 19:07

make docs

08b4075

ajiraj2411 requested a review from srebhan September 10, 2024 02:39

srebhan reviewed Sep 10, 2024

View reviewed changes

Addressed review comments

262690c

ajiraj2411 force-pushed the master branch from f89f4ee to 262690c Compare September 10, 2024 08:17

srebhan reviewed Sep 11, 2024

View reviewed changes

srebhan added the waiting for response waiting for response from contributor label Sep 16, 2024

telegraf-tiger bot closed this Sep 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(inputs.aerospike): Add latency info #15578

feat(inputs.aerospike): Add latency info #15578

ajiraj2411 commented Jun 29, 2024 •

edited

Loading

DStrand1 left a comment

telegraf-tiger bot commented Jul 23, 2024

powersj commented Jul 24, 2024

telegraf-tiger bot commented Aug 12, 2024

ajiraj2411 commented Sep 1, 2024 •

edited

Loading

DStrand1 left a comment

srebhan commented Sep 5, 2024

ajiraj2411 commented Sep 5, 2024

telegraf-tiger bot commented Sep 9, 2024

Artifact URLs

srebhan left a comment

srebhan Sep 11, 2024

srebhan Sep 11, 2024

srebhan Sep 11, 2024

telegraf-tiger bot commented Sep 30, 2024

		startTime, _ := time.Parse(time.TimeOnly, sTime)
		endTime, _ := time.Parse(time.TimeOnly, eTime)

feat(inputs.aerospike): Add latency info #15578

feat(inputs.aerospike): Add latency info #15578

Conversation

ajiraj2411 commented Jun 29, 2024 • edited Loading

Summary

Checklist

Related issues

DStrand1 left a comment

Choose a reason for hiding this comment

telegraf-tiger bot commented Jul 23, 2024

powersj commented Jul 24, 2024

telegraf-tiger bot commented Aug 12, 2024

ajiraj2411 commented Sep 1, 2024 • edited Loading

DStrand1 left a comment

Choose a reason for hiding this comment

srebhan commented Sep 5, 2024

ajiraj2411 commented Sep 5, 2024

telegraf-tiger bot commented Sep 9, 2024

Artifact URLs

srebhan left a comment

Choose a reason for hiding this comment

srebhan Sep 11, 2024

Choose a reason for hiding this comment

srebhan Sep 11, 2024

Choose a reason for hiding this comment

srebhan Sep 11, 2024

Choose a reason for hiding this comment

telegraf-tiger bot commented Sep 30, 2024

ajiraj2411 commented Jun 29, 2024 •

edited

Loading

ajiraj2411 commented Sep 1, 2024 •

edited

Loading