Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(linters): Enable import-alias-naming and redundant-import-alias rules for revive #15836

Merged
merged 16 commits into from
Oct 1, 2024
Merged

chore(linters): Enable import-alias-naming and redundant-import-alias rules for revive #15836

merged 16 commits into from
Oct 1, 2024

Conversation

zak-pawel
Copy link
Collaborator

Summary

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #15820
resolves #15825

@telegraf-tiger telegraf-tiger bot added the chore label Sep 3, 2024
srebhan
srebhan reviewed Sep 4, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this epic effort @zak-pawel! I do have some comments in the code, but in general there are two things

  1. How about fixing variable naming instead of using an alias e.g. for github.com/influxdata/telegraf/config? The variable can easily be named cfg without issues...
  2. I love your consistent aliases for internal things like common_tls, internal_whatever etc. but you deviate for influx_serializer, influx_parser or jsonparser. How about also following the pattern and use serializers_influx, parsers_influx and parsers_json instead?

plugins/aggregators/histogram/histogram.go Outdated Show resolved Hide resolved
plugins/aggregators/histogram/histogram_test.go Outdated Show resolved Hide resolved
plugins/common/kafka/config.go Outdated Show resolved Hide resolved
plugins/common/shim/config_test.go Outdated Show resolved Hide resolved
plugins/inputs/aerospike/aerospike.go Outdated Show resolved Hide resolved
plugins/inputs/p4runtime/p4runtime_test.go Outdated Show resolved Hide resolved
plugins/inputs/vault/vault_test.go Outdated Show resolved Hide resolved
plugins/outputs/azure_data_explorer/azure_data_explorer_test.go Outdated Show resolved Hide resolved
plugins/outputs/dynatrace/dynatrace.go Outdated Show resolved Hide resolved
testutil/container.go Outdated Show resolved Hide resolved
Hipska
Hipska suggested changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@Hipska Hipska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It improves overall code readability, but still have some suggestions:

plugins/common/proxy/connect.go Show resolved Hide resolved
plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_mdt.go Outdated Show resolved Hide resolved
plugins/inputs/cloudwatch/cloudwatch.go Outdated Show resolved Hide resolved
plugins/inputs/docker/docker.go Outdated Show resolved Hide resolved
plugins/inputs/gnmi/update_fields.go Outdated Show resolved Hide resolved
plugins/outputs/azure_data_explorer/azure_data_explorer_test.go Outdated Show resolved Hide resolved
plugins/outputs/dynatrace/dynatrace.go Outdated Show resolved Hide resolved
plugins/outputs/http/http.go Outdated Show resolved Hide resolved
testutil/container.go Outdated Show resolved Hide resolved
testutil/metric.go Outdated Show resolved Hide resolved
Hipska
Hipska suggested changes Sep 4, 2024
View reviewed changes
plugins/inputs/p4runtime/p4runtime.go Outdated Show resolved Hide resolved
plugins/inputs/p4runtime/p4runtime_fake_client_test.go Outdated Show resolved Hide resolved
plugins/inputs/p4runtime/p4runtime_test.go Outdated Show resolved Hide resolved
plugins/inputs/cisco_telemetry_mdt/cisco_telemetry_mdt.go Outdated Show resolved Hide resolved
plugins/common/proxy/connect.go Show resolved Hide resolved
srebhan
srebhan reviewed Sep 5, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zak-pawel! Just two more comments and I think we are good...

plugins/inputs/kafka_consumer/kafka_consumer_test.go Outdated Show resolved Hide resolved
testutil/metric.go Show resolved Hide resolved
srebhan
srebhan approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Epic! Thanks a lot @zak-pawel for your work!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Sep 5, 2024
@srebhan srebhan removed their assignment Sep 5, 2024
@zak-pawel
Merge remote-tracking branch 'upstream/master' into revive_import-ali…
4a9024c 
…as-naming_redundant-import-alias

# Conflicts:
#	plugins/outputs/exec/exec_test.go
#	plugins/outputs/prometheus_client/v1/collector.go
#	plugins/outputs/prometheus_client/v2/collector.go
@zak-pawel
logger -> log
353b661
@zak-pawel
Merge remote-tracking branch 'upstream/master' into revive_import-ali…
8d89b09 
…as-naming_redundant-import-alias

# Conflicts:
#	plugins/inputs/logstash/logstash.go
@zak-pawel
logstash merge
ce1e00c
@zak-pawel
Merge remote-tracking branch 'upstream/master' into revive_import-ali…
e8de3a4 
…as-naming_redundant-import-alias

# Conflicts:
#	plugins/inputs/aerospike/aerospike.go
#	plugins/inputs/gnmi/gnmi.go
@zak-pawel
imports
0c94a30
@zak-pawel
Merge remote-tracking branch 'upstream/master' into revive_import-ali…
1818003 
…as-naming_redundant-import-alias

# Conflicts:
#	plugins/outputs/cloudwatch_logs/cloudwatch_logs_test.go
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@DStrand1 DStrand1 merged commit 9415d8e into influxdata:master Oct 1, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.32.1 milestone Oct 1, 2024
@zak-pawel zak-pawel mentioned this pull request Oct 3, 2024
Merged
1 task
srebhan pushed a commit that referenced this pull request Oct 7, 2024
@zak-pawel @srebhan
chore(linters): Enable import-alias-naming and `redundant-import-al…
cbead68 
…ias` rules for revive (#15836)

(cherry picked from commit 9415d8e)
asaharn pushed a commit to asaharn/telegraf that referenced this pull request Oct 16, 2024
@zak-pawel @asaharn
chore(linters): Enable import-alias-naming and `redundant-import-al…
6b9bade 
…ias` rules for revive (influxdata#15836)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DStrand1 DStrand1 DStrand1 approved these changes

@srebhan srebhan srebhan approved these changes

@Hipska Hipska Hipska approved these changes

Assignees

@DStrand1 DStrand1

Labels
chore linter ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.32.1
4 participants
@zak-pawel @Hipska @srebhan @DStrand1