Skip to content

Commit

Permalink
chore: workaround new clippy failures by disabling them
Browse files Browse the repository at this point in the history
  • Loading branch information
alamb authored and wiedld committed Jan 6, 2025
1 parent 06b656c commit ae6d572
Show file tree
Hide file tree
Showing 14 changed files with 77 additions and 0 deletions.
5 changes: 5 additions & 0 deletions datafusion/catalog/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@
// specific language governing permissions and limitations
// under the License.

// Disable clippy lints that were introduced after this code was written
#![allow(clippy::needless_lifetimes)]
#![allow(clippy::unnecessary_lazy_evaluations)]
#![allow(clippy::empty_line_after_doc_comments)]

mod catalog;
mod dynamic_file;
mod schema;
Expand Down
4 changes: 4 additions & 0 deletions datafusion/common/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,10 @@

// Make cheap clones clear: https://github.com/apache/datafusion/issues/11143
#![deny(clippy::clone_on_ref_ptr)]
// Disable clippy lints that were introduced after this code was written
#![allow(clippy::needless_lifetimes)]
#![allow(clippy::unnecessary_lazy_evaluations)]
#![allow(clippy::empty_line_after_doc_comments)]

mod column;
mod dfschema;
Expand Down
8 changes: 8 additions & 0 deletions datafusion/core/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,14 @@
// Make cheap clones clear: https://github.com/apache/datafusion/issues/11143
#![cfg_attr(not(test), deny(clippy::clone_on_ref_ptr))]
#![warn(missing_docs, clippy::needless_borrow)]
// Disable clippy lints that were introduced after this code was written
#![allow(clippy::needless_return)]
#![allow(clippy::needless_lifetimes)]
#![allow(clippy::unnecessary_lazy_evaluations)]
#![allow(clippy::empty_line_after_doc_comments)]
#![allow(clippy::unnecessary_filter_map)]
#![allow(clippy::manual_div_ceil)]
#![allow(missing_docs)]

//! [DataFusion] is an extensible query engine written in Rust that
//! uses [Apache Arrow] as its in-memory format. DataFusion's target users are
Expand Down
5 changes: 5 additions & 0 deletions datafusion/execution/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@

// Make cheap clones clear: https://github.com/apache/datafusion/issues/11143
#![deny(clippy::clone_on_ref_ptr)]
// Disable clippy lints that were introduced after this code was written
#![allow(clippy::needless_return)]
#![allow(clippy::needless_lifetimes)]
#![allow(clippy::unnecessary_lazy_evaluations)]
#![allow(clippy::empty_line_after_doc_comments)]

//! DataFusion execution configuration and runtime structures
Expand Down
6 changes: 6 additions & 0 deletions datafusion/expr-common/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,12 @@
// specific language governing permissions and limitations
// under the License.

// Disable clippy lints that were introduced after this code was written
#![allow(clippy::needless_return)]
#![allow(clippy::needless_lifetimes)]
#![allow(clippy::unnecessary_lazy_evaluations)]
#![allow(clippy::empty_line_after_doc_comments)]

//! Logical Expr types and traits for [DataFusion]
//!
//! This crate contains types and traits that are used by both Logical and Physical expressions.
Expand Down
5 changes: 5 additions & 0 deletions datafusion/expr/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@

// Make cheap clones clear: https://github.com/apache/datafusion/issues/11143
#![deny(clippy::clone_on_ref_ptr)]
// Disable clippy lints that were introduced after this code was written
#![allow(clippy::needless_return)]
#![allow(clippy::needless_lifetimes)]
#![allow(clippy::unnecessary_lazy_evaluations)]
#![allow(clippy::empty_line_after_doc_comments)]

//! [DataFusion](https://github.com/apache/datafusion)
//! is an extensible query execution framework that uses
Expand Down
5 changes: 5 additions & 0 deletions datafusion/functions-aggregate-common/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,11 @@
// Make cheap clones clear: https://github.com/apache/datafusion/issues/11143
#![deny(clippy::clone_on_ref_ptr)]
// Disable clippy lints that were introduced after this code was written
#![allow(clippy::needless_return)]
#![allow(clippy::needless_lifetimes)]
#![allow(clippy::unnecessary_lazy_evaluations)]
#![allow(clippy::empty_line_after_doc_comments)]

pub mod accumulator;
pub mod aggregate;
Expand Down
5 changes: 5 additions & 0 deletions datafusion/functions-nested/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@

// Make cheap clones clear: https://github.com/apache/datafusion/issues/11143
#![deny(clippy::clone_on_ref_ptr)]
// Disable clippy lints that were introduced after this code was written
#![allow(clippy::needless_return)]
#![allow(clippy::needless_lifetimes)]
#![allow(clippy::unnecessary_lazy_evaluations)]
#![allow(clippy::empty_line_after_doc_comments)]

//! Nested type Functions for [DataFusion].
//!
Expand Down
5 changes: 5 additions & 0 deletions datafusion/functions/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@

// Make cheap clones clear: https://github.com/apache/datafusion/issues/11143
#![deny(clippy::clone_on_ref_ptr)]
// Disable clippy lints that were introduced after this code was written
#![allow(clippy::needless_return)]
#![allow(clippy::needless_lifetimes)]
#![allow(clippy::unnecessary_lazy_evaluations)]
#![allow(clippy::empty_line_after_doc_comments)]

//! Function packages for [DataFusion].
//!
Expand Down
5 changes: 5 additions & 0 deletions datafusion/optimizer/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@

// Make cheap clones clear: https://github.com/apache/datafusion/issues/11143
#![deny(clippy::clone_on_ref_ptr)]
// Disable clippy lints that were introduced after this code was written
#![allow(clippy::needless_return)]
#![allow(clippy::needless_lifetimes)]
#![allow(clippy::unnecessary_lazy_evaluations)]
#![allow(clippy::empty_line_after_doc_comments)]

//! # DataFusion Optimizer
//!
Expand Down
6 changes: 6 additions & 0 deletions datafusion/physical-expr-common/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,12 @@
//!
//! [DataFusion]: <https://crates.io/crates/datafusion>
// Disable clippy lints that were introduced after this code was written
#![allow(clippy::needless_return)]
#![allow(clippy::needless_lifetimes)]
#![allow(clippy::unnecessary_lazy_evaluations)]
#![allow(clippy::empty_line_after_doc_comments)]

pub mod binary_map;
pub mod binary_view_map;
pub mod datum;
Expand Down
5 changes: 5 additions & 0 deletions datafusion/physical-expr/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@

// Make cheap clones clear: https://github.com/apache/datafusion/issues/11143
#![deny(clippy::clone_on_ref_ptr)]
// Disable clippy lints that were introduced after this code was written
#![allow(clippy::needless_return)]
#![allow(clippy::needless_lifetimes)]
#![allow(clippy::unnecessary_lazy_evaluations)]
#![allow(clippy::empty_line_after_doc_comments)]

// Backward compatibility
pub mod aggregate;
Expand Down
8 changes: 8 additions & 0 deletions datafusion/physical-plan/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,14 @@
// Make cheap clones clear: https://github.com/apache/datafusion/issues/11143

#![deny(clippy::clone_on_ref_ptr)]
// Disable clippy lints that were introduced after this code was written
#![allow(clippy::needless_return)]
#![allow(clippy::needless_lifetimes)]
#![allow(clippy::unnecessary_lazy_evaluations)]
#![allow(clippy::empty_line_after_doc_comments)]
#![allow(clippy::unnecessary_filter_map)]
#![allow(clippy::manual_div_ceil)]
#![allow(clippy::unnecessary_first_then_check)]

//! Traits for physical query plan, supporting parallel execution for partitioned relations.
//!
Expand Down
5 changes: 5 additions & 0 deletions datafusion/sql/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,11 @@

// Make cheap clones clear: https://github.com/apache/datafusion/issues/11143
#![deny(clippy::clone_on_ref_ptr)]
// Disable clippy lints that were introduced after this code was written
#![allow(clippy::needless_return)]
#![allow(clippy::needless_lifetimes)]
#![allow(clippy::unnecessary_lazy_evaluations)]
#![allow(clippy::empty_line_after_doc_comments)]

//! This crate provides:
//!
Expand Down

0 comments on commit ae6d572

Please sign in to comment.