Skip to content

Commit

Permalink
fix: misalignment crash (#259)
Browse files Browse the repository at this point in the history
resolves #255 

The underlying issue was that the reference to wrap was removed just after the constructor was called.  The code was there probably due to a workaround bug in the previous version of node. 

May need to clean up reference to wrap when finalizer is invoked
  • Loading branch information
sehz committed Sep 26, 2023
1 parent 4088fe6 commit 309bc50
Show file tree
Hide file tree
Showing 18 changed files with 210 additions and 195 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ jobs:
fail-fast: false
matrix:
# os: [ubuntu-latest, windows-latest, macOS-latest]
os: [ubuntu-latest, macOS-latest]
os: [ubuntu-latest, macOS-13]
rust: [stable]
node-version: [ '16', '18', '20' ]
steps:
Expand Down
109 changes: 70 additions & 39 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 309bc50

Please sign in to comment.