fix(package.json): remove "react-native" export condition #1530
+85
−144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuayoes
commented
Jan 3, 2025
Comment on lines
+160
to
+168
| if (packageJson.exports["react-native"]) { | ||
| console.error( | ||
| [ | ||
| `Invalid ${packageJsonPath} exports.react-native field should not exist`, | ||
| `Remove this check once typescript types are more stable`, | ||
| `See https://github.com/infinitered/reactotron/issues/1430`, | ||
| ].join("\n") | ||
| ) | ||
| process.exit(1) |
There was a problem hiding this comment.
Prettier formatting made a bunch of noise in this file but this is the actual change
jamonholmgren
approved these changes
Jan 4, 2025
markrickert
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please verify the following:
yarn build-and-test:localpassesDescribe your PR
This PR removes the
"react-native"export condition from all of our Reactotron packages. This is a shortcut fix for #1430This PR is essentially the same solution as this community patch: #1430 (comment)
This was added in #1326 to improve errors and stack traces, but it appears that some issues with Reactotron's types are causing compilation issues with people's bundler and test setups.
This should ultimately be fixed by making Reactotron's types more robust and strict, but to improve our user experience now, we are implementing this solution.