Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(monorepo-yarn): metro fixes, CLI prompt changes, global script #184

Merged
merged 2 commits into from
Jan 10, 2025
Merged

fix(monorepo-yarn): metro fixes, CLI prompt changes, global script #184

merged 2 commits into from
Jan 10, 2025

Conversation

frankcalise
Copy link
Contributor

Description

  • Fixes to the yarn monorepo recipe
  • Global package.json script fix
  • Fixes to the metro.config.js section
  • Updates to the CLI prompt to reflect latest Ignite

@frankcalise frankcalise mentioned this pull request Jan 8, 2025
Merged
5 tasks
ecroce
ecroce reviewed Jan 8, 2025
View reviewed changes
Copy link
Contributor

@ecroce ecroce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small contradiction of locations on lines 681 to 700

docs/recipes/SettingUpYarnMonorepo.md Outdated Show resolved Hide resolved
@frankcalise frankcalise merged commit 702dfc4 into main Jan 10, 2025
1 check passed
@frankcalise frankcalise deleted the frankcalise/monorepo-yarn-fixes branch January 10, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ecroce ecroce ecroce approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frankcalise @ecroce