fix(mmkv): remove async storage pkg #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindboe
reviewed
Mar 28, 2024
docs/recipes/MigratingToMMKV.md
Outdated
| @@ -177,68 +178,68 @@ Now that you've moved the base storage functions over to MMKV, you might want to | |||
| You may notice that the `storage.test.ts` test file will no longer pass. Replace the contents of this file with the following test data: | |||
|
|
|||
| ```tsx | |||
| import { load, loadString, save, saveString, clear, remove } from "./storage" | |||
| import { storage } from "./mmkv" // <- wherever your global `new MMKV()` constant is | |||
| import { load, loadString, save, saveString, clear, remove } from "./storage"; | |||
There was a problem hiding this comment.
Are the addition of semicolons intended? No opinion either way, just wanted to check since it wasn't mentioned
There was a problem hiding this comment.
Probably an auto format thing, I'll double check with the consistency of the other snippets. Thanks!
There was a problem hiding this comment.
Going to leave it alone, seems as if the other recipes have it via the formatter.
lindboe
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Never removed the old package that we replaced inside the recipe xD