Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note about Expo Router using v3 and fix ref issue in ListItem.tsx #131

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

cdanwards
Copy link
Member

Thanks to @johnhamlin for raising an issue about this error that occurs when implementing this recipe! This PR adds in the necessary fixes to address it. #127

It also adds in a note about versioning in case someone accidentally uses the recipe in an older version of Expo.

Copy link
Contributor

@Jpoliachik Jpoliachik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 👏

@cdanwards cdanwards merged commit a31f5dc into main Feb 23, 2024
1 check passed
@cdanwards cdanwards deleted the fix/expo-router-ref branch February 23, 2024 21:11
cdanwards added a commit that referenced this pull request Feb 28, 2024
…#131)

* Add note about Expo Router using v3 and fix ref issue in ListItem.tsx

* Make code change into details section
cdanwards added a commit that referenced this pull request Feb 28, 2024
…#131)

* Add note about Expo Router using v3 and fix ref issue in ListItem.tsx

* Make code change into details section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants