LINUX_VERSION_CODE inspired cleanup #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make a simple wrapper and avoid the multiple #if checks across the codebase. Signed-off-by: Emil Velikov <[email protected]>
Older kernels name the struct differently. Use a #define to trivially workaround that. Signed-off-by: Emil Velikov <[email protected]>
2.6.35 was released over 13 years ago. I think it's fine to let go now. Signed-off-by: Emil Velikov <[email protected]>
The wg_message_handshake_cookie struct alongside all the static inline helpers are unused - remove them. The former was unused since its introduction, while the latter since commit bf30d58 Signed-off-by: Emil Velikov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While browsing through I've noticed that we have a bunch of convoluted LINUX_VERSION_CODE handling and some dead/unused code. This PR takes care of it.
Mind you, this is only compile tested.