add explicit <unistd.h> include #209
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the following compilation error with Python 3.13.0a1:
```
c-ext/backend_c.c:275:13: error: implicit declaration of function ‘sysconf’; did you mean ‘sscanf’? [-Werror=implicit-function-declaration]
275 | count = sysconf(_SC_NPROCESSORS_ONLN);
| ^~~~~~~
| sscanf
```
According to https://docs.python.org/3.13/whatsnew/3.13.html:
Python.h no longer includes the <unistd.h> standard header file.
If needed, it should now be included explicitly.
For example, it provides the functions: read(), write(), close(), isatty(), lseek(), getpid(), getcwd(), sysconf() and getpagesize().
As a consequence, _POSIX_SEMAPHORES and _POSIX_THREADS macros are no longer defined by Python.h.
The HAVE_UNISTD_H and HAVE_PTHREAD_H macros defined by Python.h can be used to decide if <unistd.h> and <pthread.h> header files can be included.
See python/cpython#108783 .
|
|
|
It will be needed for Python 3.14, though, as the upstream discussion indicates the intention to re-land the changes then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following compilation error with Python 3.13.0a1:
According to https://docs.python.org/3.13/whatsnew/3.13.html:
Python.hno longer includes the<unistd.h>standard header file. If needed, it should now be included explicitly.For example, it provides the functions:
read(),write(),close(),isatty(),lseek(),getpid(),getcwd(),sysconf()andgetpagesize(). As a consequence,_POSIX_SEMAPHORESand_POSIX_THREADSmacros are no longer defined byPython.h. TheHAVE_UNISTD_HandHAVE_PTHREAD_Hmacros defined byPython.hcan be used to decide if<unistd.h>and<pthread.h>header files can be included.See python/cpython#108783 .