Add more tests to divRound with negative numbers #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These tests actually fail, because contrary to the name, the code seems to be rounding to ceiling. Is it supposed to be like that? This was my first step at fixing #79. Modified |
|
@axic ceiling? or towards |
|
Towards zero for negatives. |
|
@axic what is left to do here? Do you have time? |
|
I don't particularly have a lot of time, but I guess this PR could be changed to add tests for the current behaviour and update documentation to reflect that. A separate PR could change behaviour as that is breaking - well, it could be just a bug too, if the document is to be the canon. Any opinions @indutny ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.