Display path of current source file in header bar #464
Conversation
Currently, the full path of the current source file will be displayed. This usually results in long path -> Need more discussions.
The path to current source file will now be calculated dynamically. If there is enough space, the full absolute path will be shown. Otherwise, the longest possible path will be shown by trimming the full absolute path from the left. If there is an update to the terminal width, the path will be recalculated when the user runs the next line of code, however the method (next, step, continue). NOTICE: Pressing Ctrl-l will redraw the screen with the current path, it doesn't recalculated the path string.
…nto display-source-file-name
|
I updated it to calculate the path string automatically to fit on 1 line Currently, path will be updated if the user executes the next line of code by pressing n, s, c in the Source window(every time DebuggerUI.interaction gets called). Ctrl-l to redraw will only redraw the current path. I don't know if it's possible for Ctrl-l to update the path as well. |
pudb/debugger.py
Outdated
| filename = filename[first_dirname_index + 1:] | ||
| return filename | ||
|
|
||
| caption = [(None, separator.join([info_string, get_source_filename()]))] |
There was a problem hiding this comment.
Thanks for working on that! This isn't quite the right way to do this IMO. Instead, this should be done in the repaint method for a widget, where Urwid supplies the amount of space available.
There was a problem hiding this comment.
I need more guidance because I'm not sure what you are referring to.
this should be done in the repaint method for a widget
Are you talking about urwid.Text.render, or some repaint code in PuDB, or something else?
There was a problem hiding this comment.
Yes, I'm talking about subclassing urwid.Widget or Text and implementing our own render method.
`Caption` will handle the display of header's content, including the current source filename
qhuy4119
force-pushed
the
display-source-file-name
branch
2 times, most recently
from
025e76b
to
d7fd7ca
Compare
- Caption is now composed of a CaptionParts namedtuple and a separator, both will be passed to Caption explicitly - separator and parts in CaptionParts will be tuples of the form (attribute, text), similar to text markup in urwid - Caption no longer overestimates the amount of text to be removed.
qhuy4119
force-pushed
the
display-source-file-name
branch
from
d7fd7ca
to
f1aef6c
Compare
…isplay-source-file-name
urwid will raise error if the content in the markup is not of type str, even when they are convertable. So we have to do the converting.
Use CaptionParts._make() when constructing CaptionParts objects to increase readability.
|
A thought on this: an optional footer might be a better place. The header currently displays very useful information that helps new users get started with using the debugger, and I don't think we should lose that. |
Currently, the full path of the current source file will be displayed.
This usually results in long path. When the path can't be displayed fully in 1 row for whatever reason (the window is resized, not enough space from the beginning,...), after a Ctrl-L (hotkey for redraw screen), it will wrap automatically, creating more rows as needed.
We have multiple options to resolve this:
shutil.get_terminal_size(), for example)Let's discuss this
fixes #170