Port to actx.np.zeros #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexfikl
commented
Aug 6, 2024
Comment on lines
+478
to
+477
| warn(f"'{type(self).__name__}.empty' is deprecated and will be removed " | ||
| f"in 2025. Use '{type(self).__name__}.zeros' instead.", | ||
| DeprecationWarning, stacklevel=2) |
There was a problem hiding this comment.
This also adds a warning that Discretization.empty is deprecated following arraycontext.
alexfikl
commented
Aug 6, 2024
alexfikl
force-pushed
the
port-actx-empty
branch
from
706ab6d
to
c7900e7
Compare
alexfikl
force-pushed
the
port-actx-empty
branch
from
c7900e7
to
295757e
Compare
|
Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus two unrelated commits that popped out while grepping for
actx.zeros😁