Remove thread implementation #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t is completed. Introduce a timeout to prevent hanging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been investigating why I am not getting notifications reliably.
I believe using threading might be causing the issue. I believe the child thread may be terminating before the request completes, due to the parent thread completing.
@ThiefMaster I believe you recommended against using threading in my original PR. My reason at the time for introducing it was to prevent any delays sending the notification would introduce. But even with good intentions my implementation wasn't going to work.
I have removed it from using a thread, and I introduced a 10 second timeout on the request. Hopefully this will fix the issue.