feat: add 3DS auth with token sale #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…plement secure session management, and add detailed logging for transaction processing
- Create FastAPI webapp to demonstrate card tokenization - Implement web interface for step-by-step flow (token → payment → result) - Add full 3DS support (method and challenge) - Resolve session persistence issue between HTTP requests - Optimize error handling and result display
joel-pcg
force-pushed
the
features-fixes
branch
from
6b6d530 to
93774b6
Compare
gustavovalverde
approved these changes
May 6, 2025
Member
gustavovalverde
left a comment
gustavovalverde
left a comment
There was a problem hiding this comment.
Approved, but need another PR to standardize to English, and fix the examples.
| @@ -0,0 +1,415 @@ | |||
| """ | |||
| Mini aplicación FastAPI para demostrar el flujo completo de pagos con token y 3DS: | |||
| return response | ||
|
|
||
| except AzulError as e: | ||
| logger.error(f"Error en Azul al procesar pago: {str(e)}") |
Member
There was a problem hiding this comment.
Logs, comments and responses in English
| showResult({ message: "Iniciando proceso de pago..." }, 'processing'); | ||
|
|
||
| const response = await fetch('/process-payment', { | ||
| const response = await fetch('/process-hold', { |
Member
There was a problem hiding this comment.
Here it indicate is a process-hold, but above and below it indicate it's a payment not a hold
| client = Mock() | ||
| client._async_request = AsyncMock() | ||
| client.settings = Mock() | ||
| client.settings.MERCHANT_ID = "39038540035" # Using the MERCHANT_ID from .env |
Member
There was a problem hiding this comment.
Do not use a hardcoded value here, it should use an environment variable
| return DataVaultCreateModel( | ||
| CardNumber="4111111111111111", # Test Visa card | ||
| Expiration="202812", | ||
| store="39038540035" |
Member
There was a problem hiding this comment.
Do not use a hardcoded value here, it should use an environment variable
gustavovalverde
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Features
1. Payment Processing with Token + 3DS
2. Hold Authorization Processing
Test Coverage
We created a robust test suite that verifies:
SecureTokenSale: Verification of all 3DS scenariosprocess_token_sale: Token sales processingprocess_hold: Hold authorization processing