Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.0.0 release #123

Merged
merged 35 commits into from
Oct 4, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
2a8df0a
Remove zip code
inderdhir Feb 8, 2023
14f5b19
Bump up minimum version to macOS 12.0
inderdhir Feb 8, 2023
a47d049
Refactor to use Swift concurrency
inderdhir Feb 8, 2023
98dd168
Update wind speed based on selected unit
inderdhir Feb 8, 2023
592b95a
Migrate city source to use Swift concurrency
inderdhir Feb 27, 2023
271be5b
Bump up min macOS version to 13.0
inderdhir Feb 27, 2023
5dd9eb0
Update code for Xcode 14
inderdhir Apr 9, 2023
d5ec99f
Add swiftlint
inderdhir Jun 5, 2023
366d332
Update SPM deps
inderdhir Jul 2, 2023
dc88c87
Update swiftlint rule
inderdhir Jul 2, 2023
01192d4
Add accessibliity description for images
inderdhir Jul 2, 2023
b5def20
Remove unused code
inderdhir Jul 2, 2023
c90d8ac
Replace custom logger with OSLog logger
inderdhir Jul 5, 2023
f680eb1
shorten error messages
eugenesvk Jul 28, 2023
074c146
feat: allow hiding unit letter and symbol (separately each)
eugenesvk Jul 14, 2023
bdf820b
remove unused vars
eugenesvk Jul 28, 2023
fcc2792
replace nested conditionals with ternary comparisons
eugenesvk Jul 28, 2023
b4178d5
feat: replace hardcoded value separator with a configurable value
eugenesvk Jul 14, 2023
82010f8
remove space separator affix
eugenesvk Jul 28, 2023
7c5e34c
Clean up code
inderdhir Aug 3, 2023
e7fa1b1
Refactor configure view
inderdhir Aug 9, 2023
5b17eba
Refactor wind direction
inderdhir Aug 9, 2023
229cbe5
Refactor weather repositories
inderdhir Aug 9, 2023
54aeeec
Remove extra enum for ConfigManager
inderdhir Aug 9, 2023
c1717e0
Clean up WeatherData struct
inderdhir Aug 9, 2023
952000d
Rename DropdownIcons enum
inderdhir Aug 9, 2023
ad2979a
Remove `ConfigurationCommiter`
inderdhir Aug 9, 2023
aeeefc9
Remove `Utils`
inderdhir Aug 9, 2023
e702297
Clean up code
inderdhir Aug 27, 2023
7906ae9
Remove "Shift" requirement from keyboard shortcuts
inderdhir Aug 27, 2023
b7c89d3
Revert "Remove zip code"
inderdhir Sep 1, 2023
48d453d
Remove "shift" and "cmd" presses from shortcuts
inderdhir Sep 1, 2023
5ab8b64
Fix default value for separator
inderdhir Oct 2, 2023
a151bf9
Add vertical spacing for options
inderdhir Oct 3, 2023
a6bf701
Fix unit tests
inderdhir Oct 4, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .swiftlint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ excluded: # paths to ignore during linting. Takes precedence over `included`.
# configurable rules can be customized from this configuration file
# configurable rules can be customized from this configuration file
# binary rules can set their severity level
cyclomatic_complexity:
ignores_case_statements: true
force_cast: warning # implicitly
force_try:
severity: warning # explicitly
Expand Down
286 changes: 130 additions & 156 deletions DatWeatherDoe.xcodeproj/project.pbxproj

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -1,12 +1,30 @@
{
"pins" : [
{
"identity" : "collectionconcurrencykit",
"kind" : "remoteSourceControl",
"location" : "https://github.com/JohnSundell/CollectionConcurrencyKit.git",
"state" : {
"revision" : "b4f23e24b5a1bff301efc5e70871083ca029ff95",
"version" : "0.2.0"
}
},
{
"identity" : "cryptoswift",
"kind" : "remoteSourceControl",
"location" : "https://github.com/krzyzanowskim/CryptoSwift.git",
"state" : {
"revision" : "32f641cf24fc7abc1c591a2025e9f2f572648b0f",
"version" : "1.7.2"
}
},
{
"identity" : "launchatlogin",
"kind" : "remoteSourceControl",
"location" : "https://github.com/sindresorhus/LaunchAtLogin",
"state" : {
"revision" : "e8171b3e38a2816f579f58f3dac1522aa39efe41",
"version" : "4.2.0"
"revision" : "7ad6331f9c38953eb1ce8737758e18f7607e984a",
"version" : "5.0.0"
}
},
{
Expand All @@ -17,6 +35,69 @@
"revision" : "c01bbdf2d633cf049ae1ed1a68a2020a8bda32e2",
"version" : "5.1.0"
}
},
{
"identity" : "sourcekitten",
"kind" : "remoteSourceControl",
"location" : "https://github.com/jpsim/SourceKitten.git",
"state" : {
"revision" : "b6dc09ee51dfb0c66e042d2328c017483a1a5d56",
"version" : "0.34.1"
}
},
{
"identity" : "swift-argument-parser",
"kind" : "remoteSourceControl",
"location" : "https://github.com/apple/swift-argument-parser.git",
"state" : {
"revision" : "fee6933f37fde9a5e12a1e4aeaa93fe60116ff2a",
"version" : "1.2.2"
}
},
{
"identity" : "swift-syntax",
"kind" : "remoteSourceControl",
"location" : "https://github.com/apple/swift-syntax.git",
"state" : {
"revision" : "59ed009d2c4a5a6b78f75a25679b6417ac040dcf",
"version" : "509.0.0-swift-DEVELOPMENT-SNAPSHOT-2023-07-04-a"
}
},
{
"identity" : "swiftlint",
"kind" : "remoteSourceControl",
"location" : "https://github.com/realm/SwiftLint",
"state" : {
"revision" : "9eaecbedce469a51bd8487effbd4ab46ec8384ae",
"version" : "0.52.4"
}
},
{
"identity" : "swiftytexttable",
"kind" : "remoteSourceControl",
"location" : "https://github.com/scottrhoyt/SwiftyTextTable.git",
"state" : {
"revision" : "c6df6cf533d120716bff38f8ff9885e1ce2a4ac3",
"version" : "0.9.0"
}
},
{
"identity" : "swxmlhash",
"kind" : "remoteSourceControl",
"location" : "https://github.com/drmohundro/SWXMLHash.git",
"state" : {
"revision" : "a853604c9e9a83ad9954c7e3d2a565273982471f",
"version" : "7.0.2"
}
},
{
"identity" : "yams",
"kind" : "remoteSourceControl",
"location" : "https://github.com/jpsim/Yams.git",
"state" : {
"revision" : "0d9ee7ea8c4ebd4a489ad7a73d5c6cad55d6fed3",
"version" : "5.0.6"
}
}
],
"version" : 2
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
<?xml version="1.0" encoding="UTF-8"?>
<Scheme
LastUpgradeVersion = "1420"
LastUpgradeVersion = "1500"
version = "1.7">
<BuildAction
parallelizeBuildables = "YES"
Expand Down
17 changes: 7 additions & 10 deletions DatWeatherDoe/API/NetworkClient.swift
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,13 @@

import Foundation

final class NetworkClient {
protocol NetworkClientType {
func performRequest(url: URL) async throws -> Data
}

final class NetworkClient: NetworkClientType {

func performRequest(url: URL, completion: @escaping (Result<Data, Error>) -> Void) {
URLSession.shared.dataTask(with: url) { data, _, error in
guard let data = data, error == nil else {
completion(.failure(WeatherError.networkError))
return
}

completion(.success(data))
}.resume()
func performRequest(url: URL) async throws -> Data {
try await URLSession.shared.data(from: url).0
}
}
80 changes: 0 additions & 80 deletions DatWeatherDoe/API/Repository/City/CityWeatherRepository.swift

This file was deleted.

This file was deleted.

This file was deleted.

Loading