Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass R CMD Check #321

Merged
merged 6 commits into from
Sep 30, 2024
Merged

pass R CMD Check #321

merged 6 commits into from
Sep 30, 2024

Conversation

PietrH
Copy link
Member

@PietrH PietrH commented Sep 30, 2024

This PR includes a number of small changes that fix some notes and errors in R CMD CHECK in advance of the v2.3 beta release

checking R code for possible problems ... NOTE
  Found if() conditions comparing class() to string:
  File ‘etn/R/list_values.R’: if (class(arguments$column) == "name") ...
  Use inherits() (or maybe is()) instead.
@PietrH PietrH self-assigned this Sep 30, 2024
@PietrH PietrH marked this pull request as ready for review September 30, 2024 12:56
@PietrH PietrH merged commit d0842c5 into v2.3 Sep 30, 2024
@PietrH PietrH deleted the 307-r-cmd-check-fails-on-v23 branch September 30, 2024 12:56
@PietrH PietrH linked an issue Sep 30, 2024 that may be closed by this pull request
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

R CMD CHECK fails on v2.3
1 participant