Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require R3.6.0 or higher #138

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Require R3.6.0 or higher #138

wants to merge 1 commit into from

Conversation

peterdesmet
Copy link
Member

No description provided.

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.89%. Comparing base (8c4981e) to head (567f397).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #138   +/-   ##
=======================================
  Coverage   99.89%   99.89%           
=======================================
  Files          22       22           
  Lines         958      958           
=======================================
  Hits          957      957           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterdesmet
Copy link
Member Author

@PietrH or @sannegovaert can you have a look at this one? The R3.6.0 check fails because in old version of R, the columns with strings get converted to factors. This then fails the expect_identical() test. It seems to happen in the taxa() data frame, where e.g. taxonID, vernacularName, etc. are factors, likely around here:

camtrapdp/R/taxa.R

Lines 20 to 26 in 8c4981e

taxa <-
observations(x) %>%
dplyr::filter(!is.na(.data$scientificName)) %>%
dplyr::select("scientificName", dplyr::starts_with("taxon.")) %>%
dplyr::distinct() %>%
dplyr::rename_with(~ sub("^taxon.", "", .x)) %>%
dplyr::arrange(scientificName)

We solved a similar error in frictionless here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant