Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New function merge_camtrapdp() #112

Open
wants to merge 111 commits into
base: main
Choose a base branch
from
Open

New function merge_camtrapdp() #112

wants to merge 111 commits into from

Conversation

sannegovaert
Copy link
Member

@sannegovaert sannegovaert commented Jul 25, 2024

fix #75

Remarks

  • Assume that locationID's and individualID's must not be unique as the same location or individual can be used in different data packages.
  • Assume that duplicatesd ID's are between packages, not within.
  • If duplicates are present, all values of that identifier get a prefix.

Helper functions
I created 6 helper functions. Maybe they can be simplified or reduced in number!
They now live at utils.R.

function functionality in merge_camtrapdp() suggestion
check_duplicate_ids() add prefix to identifiers with duplicates helper function @ utils.R
add_prefix() add prefix to identifiers with duplicates helper function @ utils.R
normalize_list() remove duplicated elements of lists helper function @ utils.R or separate file.R
is_subset() remove duplicated elements of lists helper function @ utils.R or separate file.R
update_unique() remove duplicated elements of lists helper function @ utils.R or separate file.R
remove_duplicates() remove duplicated elements of lists helper function @ utils.R or separate file.R

Copy link

codecov bot commented Jul 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.91%. Comparing base (8c4981e) to head (74983fd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #112      +/-   ##
==========================================
+ Coverage   99.89%   99.91%   +0.01%     
==========================================
  Files          22       23       +1     
  Lines         958     1148     +190     
==========================================
+ Hits          957     1147     +190     
  Misses          1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterdesmet peterdesmet marked this pull request as ready for review October 17, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create merge() to merge datasets
2 participants