Update exercices to use Effect instead of fp-ts #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds Effect dependencies
kevintc
force-pushed
the
convert-to-Effect
branch
from
e6c5383 to
0532cee
Compare
LaureRC
reviewed
Apr 28, 2025
src/exo4 - Dependency injection with Reader/exo4.effect.exercise.ts
Outdated
Show resolved
Hide resolved
LaureRC
reviewed
Apr 28, 2025
LaureRC
reviewed
Apr 28, 2025
src/exo0 - Composing with pipe and flow/exo0.effect.exercise.ts
Outdated
Show resolved
Hide resolved
LaureRC
reviewed
Apr 28, 2025
LaureRC
reviewed
Apr 28, 2025
|
Sure you don't want to either:
Because I've often heard people talk about this repo so to me it sounds look like a bit of a landmark for |
LaureRC
reviewed
Apr 28, 2025
LaureRC
reviewed
Apr 28, 2025
LaureRC
reviewed
Apr 28, 2025
LaureRC
reviewed
Apr 28, 2025
Contributor
Author
@FredericEspiau, we will probably split the 2 repositories, it's just convenient at first to have both versions while we work on porting the exercices from |
LaureRC
reviewed
Apr 28, 2025
LaureRC
reviewed
Apr 29, 2025
src/exo0 - Composing with pipe and flow/exo0.effect.exercise.ts
Outdated
Show resolved
Hide resolved
LaureRC
reviewed
Apr 29, 2025
LaureRC
reviewed
Apr 29, 2025
LaureRC
reviewed
Apr 29, 2025
LaureRC
reviewed
Apr 29, 2025
LaureRC
reviewed
Apr 29, 2025
LaureRC
reviewed
Apr 29, 2025
LaureRC
reviewed
Apr 29, 2025
LaureRC
reviewed
Apr 29, 2025
LaureRC
reviewed
Apr 29, 2025
LaureRC
reviewed
Apr 29, 2025
| // Implement this function using Effect's APIs | ||
| pipe( | ||
| optionalCountryCode, | ||
| Option.match({ |
Contributor
There was a problem hiding this comment.
Effect equivalent of option.traverse here would be Effect.transposeMapOption that I added recently in Effect 😏 let's use it! :)
- Removes unused import. - Corrects Either type parameter order to align with the Effect library's convention. - Introduces `Effect.transposeMapOption` for simplifying Option transformations. - Streamlines array traversal using `Option.all` instead of manual reduction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/!\ This is a simple translation of the exercices, it could benefit from a broader view on how to implement other concepts from Effect that are not part of the current exercices.
How to review:
fp-tstoEffectis correct