-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #254: Upgrade Django 1.8 #314
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #314 +/- ##
==========================================
- Coverage 52.37% 52.27% -0.1%
==========================================
Files 92 92
Lines 4344 4344
Branches 388 388
==========================================
- Hits 2275 2271 -4
- Misses 1993 1997 +4
Partials 76 76
Continue to review full report at Codecov.
|
@lucernae Yes, I'll try to contribute :-) |
BTW @lucernae what was the previous Django version before this upgrade? I found it's already pinning to 1.8. I am planning to fix this:
|
Yes @za We're already using Django 1.8 but some view function convention is still using the old one. |
1 similar comment
Yes @za We're already using Django 1.8 but some view function convention is still using the old one. |
|
||
# set up devserver if installed | ||
try: | ||
import devserver # noqa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes we should remove this, we're not using devserver anymore. It's harder to configure and superseded by docker compose.
@lucernae OK ;-) |
#254