Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #254: Upgrade Django 1.8 #314

Merged
merged 1 commit into from
Oct 28, 2018

Conversation

za
Copy link
Contributor

@za za commented Oct 4, 2018

@codecov
Copy link

codecov bot commented Oct 4, 2018

Codecov Report

Merging #314 into develop will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #314     +/-   ##
==========================================
- Coverage    52.37%   52.27%   -0.1%     
==========================================
  Files           92       92             
  Lines         4344     4344             
  Branches       388      388             
==========================================
- Hits          2275     2271      -4     
- Misses        1993     1997      +4     
  Partials        76       76
Impacted Files Coverage Δ
django_project/realtime/models/earthquake.py 79.22% <0%> (-1.3%) ⬇️
django_project/realtime/tasks/earthquake.py 34.61% <0%> (-1.1%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ba2a63...2a89a1a. Read the comment docs.

@lucernae
Copy link
Contributor

lucernae commented Oct 4, 2018

Thanks for contributing as always @za :).
Do you plan on working on this issue #254 ?
We are currently short on hand.
We already upgraded some part to Django 1.8, but not all.
We really appreciate if you can fix some convention to proper Django 1.8 even some part of it :D

@za
Copy link
Contributor Author

za commented Oct 5, 2018

@lucernae Yes, I'll try to contribute :-)

@za za changed the title Issue 254: Upgrade Django 1.8 Issue #254: Upgrade Django 1.8 Oct 5, 2018
@za
Copy link
Contributor Author

za commented Oct 5, 2018

BTW @lucernae what was the previous Django version before this upgrade? I found it's already pinning to 1.8. I am planning to fix this:

Django context needs to be separated because of new function convention:

@lucernae
Copy link
Contributor

Yes @za We're already using Django 1.8 but some view function convention is still using the old one.
BTW, I'm going to merge this because we're not using devserver anymore.
Thanks!

1 similar comment
@lucernae
Copy link
Contributor

Yes @za We're already using Django 1.8 but some view function convention is still using the old one.
BTW, I'm going to merge this because we're not using devserver anymore.
Thanks!


# set up devserver if installed
try:
import devserver # noqa
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we should remove this, we're not using devserver anymore. It's harder to configure and superseded by docker compose.

@lucernae lucernae merged commit 4ee24b4 into inasafe:develop Oct 28, 2018
@za
Copy link
Contributor Author

za commented Oct 29, 2018

@lucernae OK ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants