make egithub_webhook:request() type opaque #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cabol
reviewed
Oct 31, 2016
| %%% | ||
| %%% @end | ||
| %%% Created : 28. Oct 2016 11:11 AM | ||
| %%%------------------------------------------------------------------- |
There was a problem hiding this comment.
Please remove or fix these comments (from line 1 to 8). I'd let only de @doc section, so you can add a brief description about the module.
cabol
reviewed
Oct 31, 2016
| %%% | ||
| %%% @end | ||
| %%% Created : 28. Oct 2016 11:40 AM | ||
| %%%------------------------------------------------------------------- |
There was a problem hiding this comment.
Please remove or fix these comments (from line 1 to 8). I'd let only de @doc section, so you can add a brief description about the module.
cabol
reviewed
Oct 31, 2016
| @@ -0,0 +1,40 @@ | |||
| %%%------------------------------------------------------------------- | |||
There was a problem hiding this comment.
Please translate this test from EUnit to Common Test.
|
@mfelsche please update your branch, I think there aren't conflicts, but better be sure! |
mfelsche
force-pushed
the
opaque_webhook_request
branch
from
5e04292 to
337d04a
Compare
and move creation and extraction into its own module
mfelsche
force-pushed
the
opaque_webhook_request
branch
from
337d04a to
29800b9
Compare
|
i addressed all the comments. |
|
@elbrujohalcon from my side, I see everything OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and move creation and extraction into its own module.
this solves #117
though i actually didn't see any place in erlang-githubs codebase where a requests body was accessed multiple times.