-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix protocol_for_deps
allow for git_subdir
's ref
and tag
#373
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, although I would add support for git://
, as well.
I'm spelunking into the code: Edit: oh, I think I see it... 12a966e If we're still interested in supporting Erlang.mk we should keep it, but it needs to be updated; otherwise we can drop it. |
Description
We:
branch
forgit_subdir
raw
resources with comments (so future-us knows where those references come from)rebar3
supports it as legacy, I believe we should too.Closes #370.