Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix protocol_for_deps allow for git_subdir's ref and tag #373

Merged
merged 11 commits into from
Nov 12, 2024

Conversation

paulo-ferraz-oliveira
Copy link
Collaborator

Description

We:

  • improve matching on branch for git_subdir
  • identify raw resources with comments (so future-us knows where those references come from)
  • allow for a new (though only for backwards compatibility) "with opts" match
    • it's unlikely it's commonly used, but since rebar3 supports it as legacy, I believe we should too.

Closes #370.

Copy link
Member

@elbrujohalcon elbrujohalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, although I would add support for git://, as well.

@paulo-ferraz-oliveira
Copy link
Collaborator Author

paulo-ferraz-oliveira commented Nov 11, 2024

I'm spelunking into the code: [0-9]+([.][0-9]+)*) was introduced in the regex in 0.2.9, but I'm still trying to find why (or what for).

Edit: oh, I think I see it... 12a966e If we're still interested in supporting Erlang.mk we should keep it, but it needs to be updated; otherwise we can drop it.

@elbrujohalcon elbrujohalcon merged commit 6e0582c into main Nov 12, 2024
7 checks passed
@elbrujohalcon elbrujohalcon deleted the fix/protocol_for_deps branch November 12, 2024 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rebar3 dependency "git_subdir" tag not supported for tag (rule: protocol_for_deps)
2 participants