elbrujohalcon.571.update-deps Apply new elvis rules

elvis.config

@@ -7,10 +7,6 @@
         filter => "*.erl",
         ruleset => erl_files
        },
-      #{dirs => ["."],
-        filter => "Makefile",
-        ruleset => makefiles
-       },
       #{dirs => ["."],
         filter => "rebar.config",
         ruleset => rebar_config

src/elvis.erl

@@ -142,7 +142,7 @@ process_options([{parallel, Num} | Opts], Cmds, Config) ->
 process_options([], Cmds, Config) ->
     process_commands(Cmds, Config).
 
--spec process_commands([string()], elvis_config:configs()) ->ok.
+-spec process_commands([string()], elvis_config:configs()) -> ok.
 process_commands([rock | Files], Config) ->
     case Files of
         [] ->
@@ -168,7 +168,7 @@ process_commands(['git-branch', Commit | Cmds], Config) ->
 process_commands([], _Config) ->
     ok;
 process_commands([_Cmd | _Cmds], _Config) ->
-    throw(unrecognized_or_unimplemented_command).
+    error(unrecognized_or_unimplemented_command).
 
 %%% Options
 

src/elvis_git.erl

@@ -106,7 +106,7 @@ install_hook() ->
 check_git_dir() ->
     case filelib:is_dir(".git") of
         true -> ok;
-        false -> throw("Not a git repository.")
+        false -> error("Not a git repository.")
     end.
 
 %% @doc Adds elvis as a pre commit hook. If a pre-commit file already exists
@@ -123,7 +123,7 @@ add_pre_commit_hook() ->
                 {ok, Content} = file:read_file(?PRE_COMMIT_FILE),
                 case binary:match(Content, <<"elvis">>) of
                     nomatch -> {[append], Command};
-                    _ ->  throw("Elvis is already installed as a git hook.")
+                    _ -> error("Elvis is already installed as a git hook.")
                 end;
             false -> {[write], <<Header/binary, Command/binary>>}
         end,
@@ -155,7 +155,7 @@ patch_line_type(Line) ->
         $+  -> addition;
         $-  -> deletion;
         $\\ -> same;
-        $   -> same %space
+        $\s -> same %space
     end.
 
 %% @private

src/elvis_webhook.erl

@@ -50,10 +50,8 @@ handle_pull_request(Cred, Data, GithubFiles) ->
                    comments => []}}
     end.
 
--spec handle_error( {error, term()}
-                  , egithub_webhook:req_data()
-                  , [egithub_webhook:file()]
-                  ) -> {ok, [], []}.
+-spec handle_error(
+    {error, term()}, egithub_webhook:req_data(), [egithub_webhook:file()]) -> {ok, [], []}.
 handle_error({error, _}, _, _) -> {ok, [], []}.
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%

test/elvis_SUITE.erl

@@ -32,7 +32,8 @@
          end_per_suite
         ]).
 
--type config() :: [{atom(), term()}].
+-type config() :: proplists:proplist().
+-export_type([config/0]).
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 %% Common test
@@ -240,7 +241,7 @@ main_default_config(_Config) ->
         meck:expect(elvis_utils, erlang_halt, fun(Code) -> Code end),
         Src = "../../config/elvis-test.config",
         Dest = "./elvis.config",
-        {ok , _} = file:copy(Src, Dest),
+        {ok, _} = file:copy(Src, Dest),
 
         Expected = "# ../../src/elvis.erl.*OK",
         RockFun = fun() -> elvis:main("rock") end,

test/elvis_meta_SUITE.erl

@@ -1,10 +1,10 @@
 -module(elvis_meta_SUITE).
--author('[email protected]').
 
 -export([all/0]).
 -export([dialyzer/1, xref/1, elvis/1]).
 
--type config() :: [{atom(), term()}].
+-type config() :: proplists:proplist().
+-export_type([config/0]).
 
 -spec all() -> [dialyzer | xref | elvis].
 all() -> [dialyzer, xref, elvis].

test/git_SUITE.erl

@@ -20,7 +20,8 @@
          end_per_suite
         ]).
 
--type config() :: [{atom(), term()}].
+-type config() :: proplists:proplist().
+-export_type([config/0]).
 
 %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%
 %% Common test
@@ -129,4 +130,3 @@ maybe_git_config_user() ->
             _ = os:cmd("git config user.name 'Your Name'"),
             ok
     end.
-

test/xref_SUITE.erl

@@ -1,6 +1,7 @@
 -module(xref_SUITE).
 
 -type config() :: proplists:proplist().
+-export_type([config/0]).
 
 -export(
    [