Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async streams, max streams from settings http/2 frame #257

Closed
wants to merge 3 commits into from

Conversation

sedinin
Copy link
Collaborator

@sedinin sedinin commented Apr 17, 2024

tested with connection type 'token' only

Copy link
Member

@elbrujohalcon elbrujohalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks reasonable to me (modulo the minor changes I'm requesting), but I'll defer the final approval to @ferigis .

@sedinin would it be possible to add / adjust tests to verify your changes?

src/apns_connection.erl Outdated Show resolved Hide resolved
src/apns_connection.erl Outdated Show resolved Hide resolved
src/apns_connection.erl Outdated Show resolved Hide resolved
@sedinin
Copy link
Collaborator Author

sedinin commented Apr 24, 2024

One more change here (forget about it before): need to update gun version to 2+, option
to get info from settings frame ('notify_settings_changed') appeared only in 2.0.
So i updated rebar.config too

Copy link
Member

@elbrujohalcon elbrujohalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strange indentation again, sorry.

src/apns_connection.erl Outdated Show resolved Hide resolved
Copy link
Member

@elbrujohalcon elbrujohalcon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me but I'll defer merging of this PR to @ferigis

@dsrosario
Copy link
Collaborator

This PR was merged to #258. @sedinin, I think we should close this PR and only focus on that one. What do you think?

@dsrosario
Copy link
Collaborator

Dropping this PR. It is part of #258 .

@dsrosario dsrosario closed this Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants