Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use master branch of chatterbox #202

Closed
wants to merge 1 commit into from
Closed

Use master branch of chatterbox #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rebar.config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
%% == Dependencies ==

{deps, [
{chatterbox, "0.5.0"},
{chatterbox, {git, "https://github.com/joedevivo/chatterbox.git", {branch, "master"}}},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better to use something like {ref, "f5b68963bc63b3b2cf8701fafe61cfae9c0a383f"} here :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, if we want to stay there. Usually I let the .lock file track these. But I can make this change if needed :)

{jsx, "2.8.2"},
{base64url, "0.0.1"}
]}.
Expand Down
6 changes: 4 additions & 2 deletions rebar.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
{"1.1.0",
[{<<"base64url">>,{pkg,<<"base64url">>,<<"0.0.1">>},0},
{<<"chatterbox">>,{pkg,<<"chatterbox">>,<<"0.5.0">>},0},
{<<"chatterbox">>,
{git,"https://github.com/joedevivo/chatterbox.git",
{ref,"f5b68963bc63b3b2cf8701fafe61cfae9c0a383f"}},
0},
{<<"goldrush">>,{pkg,<<"goldrush">>,<<"0.1.9">>},2},
{<<"hpack">>,{pkg,<<"hpack_erl">>,<<"0.2.3">>},1},
{<<"jsx">>,{pkg,<<"jsx">>,<<"2.8.2">>},0},
{<<"lager">>,{pkg,<<"lager">>,<<"3.2.4">>},1}]}.
[
{pkg_hash,[
{<<"base64url">>, <<"36A90125F5948E3AFD7BE97662A1504B934DD5DAC78451CA6E9ABF85A10286BE">>},
{<<"chatterbox">>, <<"69F5A1F36F905472B7662A301E67309DD3CAE7D0CA1B2E52C14D43EE7DF4C3A3">>},
{<<"goldrush">>, <<"F06E5D5F1277DA5C413E84D5A2924174182FB108DABB39D5EC548B27424CD106">>},
{<<"hpack">>, <<"17670F83FF984AE6CD74B1C456EDDE906D27FF013740EE4D9EFAA4F1BF999633">>},
{<<"jsx">>, <<"7ACC7D785B5ABE8A6E9ADBDE926A24E481F29956DD8B4DF49E3E4E7BCC92A018">>},
Expand Down