Helm charts redirect #81
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for in-toto ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
In order to support assets inside of other domains (e.g., our github pages), we need to add support for sending 301/302 replies. Add a layout that provides a redirect to the configured target. This uses a template such as: --- type: redirect target: location --- This is inspired by this blogpost: https://blog.builtwithcaffeine.cloud/posts/hugo-url-redirect/ Signed-off-by: Santiago Torres-Arias <[email protected]>
Our helm-charts subproject requires a repository hosted on github pages (for simplicity). Add a redirect endpoint in in-toto.io to our github pages for helm-charts. Signed-off-by: Santiago Torres-Arias <[email protected]>
SantiagoTorres
force-pushed
the
helm-charts-redirect
branch
from
b05a53c to
c7f40b3
Compare
kairoaraujo
approved these changes
Dec 8, 2024
chalin
reviewed
Dec 16, 2024
There was a problem hiding this comment.
Very interesting, I didn't know about that Hugo functionality ... and can't even find any reference to it in the Hugo docs. nor (after a quick search) in the Hugo code repo. Found it: https://github.com/gohugoio/hugo/blob/master/tpl/tplimpl/embedded/templates/alias.html
Can you offer any referenes @SantiagoTorres?
Following the site rework of #86, this PR will need to be reimplemented. Let me give it a try.
|
Let's track any discussion via: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to host our helm-charts repository on github pages (to decouple updating the repository) for that project. Let's add a redirect on netlify to that github repo for ease of discovery as well.