Python in CI/CD, add lintage and tests #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Signed-off-by: William Woodruff <[email protected]>
Needed for `make reformat` on generated code. Signed-off-by: William Woodruff <[email protected]>
joshuagl
reviewed
Dec 11, 2023
marcelamelara
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Thanks for theses updates @woodruffw !
I think this also addresses/supersedes #247. So I'll close that once this is merged.
|
@woodruffw I assume this branch may need to be rebased wrt main? Can you pls resolve the conflicts? |
Signed-off-by: William Woodruff <[email protected]>
Done! |
joshuagl
approved these changes
Dec 13, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
python.ymlworkflow, which contains both a test matrix and a linting job.It also adds a convenience
Makefilefor performing common developer tasks on the Python binding.Closes #247.