Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring pkg Archivista API and include new http client for Archivista #424

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kairoaraujo
Copy link
Collaborator

What this PR does / why we need it

  • Refactor package Archivista API
  • Add package Archivista HTTP Client

Acceptance Criteria Met

  • Docs changes if needed
  • Testing changes if needed
  • All workflow checks passing (automatically enforced)
  • All review conversations resolved (automatically enforced)
  • DCO Sign-off

Special notes for your reviewer:

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 37.58389% with 93 lines in your changes missing coverage. Please review.

Project coverage is 1.84%. Comparing base (a035c62) to head (e41b846).
Report is 207 commits behind head on main.

Files with missing lines Patch % Lines
pkg/http-client/client.go 37.75% 58 Missing and 3 partials ⚠️
pkg/api/download.go 18.18% 26 Missing and 1 partial ⚠️
pkg/api/graphql.go 66.66% 2 Missing and 1 partial ⚠️
pkg/api/upload.go 75.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #424       +/-   ##
==========================================
- Coverage   82.40%   1.84%   -80.56%     
==========================================
  Files          10     124      +114     
  Lines         358   33565    +33207     
==========================================
+ Hits          295     620      +325     
- Misses         43   32883    +32840     
- Partials       20      62       +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

add a pkg with a HTTP client for Archivista using the pkg API

Signed-off-by: Kairo Araujo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant