Refactoring pkg Archivista API and include new http client for Archivista #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #424 +/- ##
==========================================
- Coverage 82.40% 1.82% -80.58%
==========================================
Files 10 124 +114
Lines 358 33571 +33213
==========================================
+ Hits 295 612 +317
- Misses 43 32897 +32854
- Partials 20 62 +42 ☔ View full report in Codecov by Sentry. |
kairoaraujo
force-pushed
the
refactor_api_http_client
branch
2 times, most recently
from
b9f3d19 to
e41b846
Compare
kairoaraujo
force-pushed
the
refactor_api_http_client
branch
from
e41b846 to
b8e39fd
Compare
kairoaraujo
force-pushed
the
refactor_api_http_client
branch
from
b8e39fd to
59caa5a
Compare
jkjell
reviewed
Dec 5, 2024
| ) | ||
| } | ||
|
|
||
| func (ac *ArchivistaClient) GraphQLQueryIface( |
There was a problem hiding this comment.
Is this function intended to be used by a user? It would probably be helpful to have some descriptions above the functions, that way they will show up in https://pkg.go.dev/
Signed-off-by: Kairo Araujo <[email protected]>
add a pkg with a HTTP client for Archivista using the pkg API Signed-off-by: Kairo Araujo <[email protected]>
Signed-off-by: Kairo Araujo <[email protected]>
kairoaraujo
force-pushed
the
refactor_api_http_client
branch
from
59caa5a to
75a5462
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Acceptance Criteria Met
Special notes for your reviewer: