-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include Metadata Schema #269
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Kairo Araujo <[email protected]>
Signed-off-by: Kairo Araujo <[email protected]>
func (Metadata) Fields() []ent.Field { | ||
return []ent.Field{ | ||
field.String("key").NotEmpty().Comment("Key value for the metadata item"), | ||
field.String("value").NotEmpty().Comment("Value for the metadata item"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jkjell,
Should we have a string as a value or any data structure?
Any data structure could bring some flexibility, such as in the unrecognized fields TUF uses.
IMO, it helps a lot in application integrations or even operational usage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️ the idea. The biggest unknown for me is if/how that complicates the creation of metadata (i.e. if we go the HTTP header route or something else)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest having it in the DSSE envelope JSON, but I know many people disagree.
{
"payload": "payload.....",
"payloadType": "https://witness.testifysec.com/...",
"signatures": [
{
"keyid": "keyid...",
"sig": "signature..."
}
],
"metadata": "any"
}
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #269 +/- ##
==========================================
- Coverage 82.40% 1.40% -81.00%
==========================================
Files 10 125 +115
Lines 358 31290 +30932
==========================================
+ Hits 295 441 +146
- Misses 43 30792 +30749
- Partials 20 57 +37 ☔ View full report in Codecov by Sentry. |
What this PR does / why we need it
Include Metadata Schema for the DSSE envelopes.
Acceptance Criteria Met
Special notes for your reviewer: