feat: newgrounds video & audio support #682
Open
+220
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyperdefined
force-pushed
the
newgrounds-support
branch
2 times, most recently
from
6080dfb to
4c4aa87
Compare
|
PR updated for cobalt 10, also added support for picking quality (if the video has it). If the video doesn't not have the quality selected, it will pick one closer. |
hyperdefined
force-pushed
the
newgrounds-support
branch
2 times, most recently
from
d23a70c to
a0b5790
Compare
hyperdefined
force-pushed
the
newgrounds-support
branch
from
a0b5790 to
38d5d02
Compare
hyperdefined
force-pushed
the
newgrounds-support
branch
from
38d5d02 to
3652c64
Compare
|
Updated again, moved tests to new format. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a cleaner version of my previous pull request, no ugly history this time.
adds support for newgrounds video & music.
example links:
videos are returned as the highest quality available. support for picking the resolution could be added easily, since newgrounds stores multiple resolutions.this pull request would close #620 (except for art, but I don't see a reason for it being added here).