Add module descriptors inside multi-release jar (#464) #553
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #464 . Per my comment on that issue, I've proceeded with my assumption that the driver's public API consists of the
api
andjdbc
packages and sub-packages. If that's not the case, let me know and I will modify the module metadata accordingly.As this PR raises the build-time JDK requirement to Java 11, I've added the
--release
flag to ensure compatibility. The release flag is like Animal-Sniffer, but better. It prevents you from calling Java 11 methods allowing you to remain Java 8-compatible – it even handles covariant return types.Because of the JDK 11 build-time requirement, I've updated the Github workflow as well.