Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add module descriptors inside multi-release jar (#464) #553

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

A248
Copy link

@A248 A248 commented Jul 11, 2021

Fixes #464 . Per my comment on that issue, I've proceeded with my assumption that the driver's public API consists of the api and jdbc packages and sub-packages. If that's not the case, let me know and I will modify the module metadata accordingly.

As this PR raises the build-time JDK requirement to Java 11, I've added the --release flag to ensure compatibility. The release flag is like Animal-Sniffer, but better. It prevents you from calling Java 11 methods allowing you to remain Java 8-compatible – it even handles covariant return types.

Because of the JDK 11 build-time requirement, I've updated the Github workflow as well.

@A248
Copy link
Author

A248 commented Jul 12, 2021

Would you like an integration test to verify the contents of META-INF/services/ match up with the provides directives in the module descriptor?

@kdubb
Copy link
Member

kdubb commented Aug 14, 2021

@A248 Can you check the build error? It doesn't seem to build at all on CI.

@A248
Copy link
Author

A248 commented Aug 15, 2021

@A248 Can you check the build error? It doesn't seem to build at all on CI.

I see it now. However, I tried and failed to reproduce the failure locally. Both gradle classes and gradle clean classes succeed for me without issue – these task runs also create the driver and spy jars.

I'd have to guess it relates to Gradle's caching mechanisms, so I've added a temporary commit to check that, which I'll revert later. The workflow run needs your approval, though.

@A248
Copy link
Author

A248 commented Nov 18, 2021

@kdubb I came back to this and tackled the build failure. I managed to reproduce the compilation failure and solve the issue.

Let me know if there are any other changes I need to make.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pgjdbc-ng missing module-info
2 participants